Repository navigation
docs: add consolidated schema reference - #17
Conversation
atomize-lab
left a comment
There was a problem hiding this comment.
Maintainer review — changes requested
The schema tables and README link are well scoped, and the deterministic checks pass. One acceptance item remains blocking:
CS-17-001 — Blocking — missing the #12 minimum tweet.json example
Location: docs/schema-reference.md (the tweet.json section, before the field table is a natural placement)
#12 was explicitly folded into #2's acceptance criteria, requiring a copy-pasteable minimum tweet.json example. This diff contains no fenced JSON example, so a reader still cannot copy a minimal document from the new reference page.
Please add a valid fenced json object containing at least the four required fields (tweet_id, tweet_url, author_handle, datetime_utc), with concrete placeholder values. Including the recommended fields with minimal values is preferable if the example is intended to validate without warnings.
Deterministic verification performed at c902e280199c
- Environment: pytest 9.1.1; pyflakes 3.4.0 import succeeded from the repository
.venv. - Full suite: 242 passed, 1 warning.
- CLI lint: passed using the repository
.venv/bin/pyflakes. - Fixture validation: 1 directory, 0 errors, 0 warnings.
- Schema coverage: tweet top-level 10/10, agent bundle 35/35, manifest 41/41; all three required table headers exist; all relative links resolve.
- #12 acceptance probe: failed (
0fenced JSON blocks / no minimum example).
Please update the draft and re-request review; no maintainer edits were made to the contributor branch.
Review summaryVerdict: changes requested — deterministic tests and schema-field coverage pass, but The PR remains the sole authoritative implementation for #2. Please push the documentation fix to this branch and re-request review. |
|
Thanks for the review. I added the requested copy-pasteable minimum Validation completed on the updated branch: |
atomize-lab
left a comment
There was a problem hiding this comment.
Maintainer re-review — approved
The new commit resolves CS-17-001: docs/schema-reference.md now contains a copy-pasteable fenced JSON example with all four required and all six recommended top-level tweet.json fields. The example passes the real validator with 0 errors and 0 warnings.
Deterministic verification at c5a94f10f447
- Repository environment: pytest 9.1.1; pyflakes 3.4.0 import succeeded from the repository
.venv. - Full suite: 242 passed, 1 warning.
- CLI lint: passed using the repository
.venv/bin/pyflakes. - Fixture validation: 1 directory, 0 errors, 0 warnings.
- Schema coverage: tweet top-level 10/10, agent bundle 35/35, manifest 41/41; required flags match both JSON Schemas.
- Documentation gates: all three table headers present, README link present, relative links resolve.
- Minimum example: one fenced JSON block, all 10 expected top-level keys, validator 0 errors / 0 warnings.
No blocking correctness, compatibility, security, or maintainability findings remain in the PR diff. No maintainer edits were made to the contributor branch. The PR is still a draft, so please mark it ready for review when you consider it complete.
Re-review summaryVerdict: acceptance checks pass; latest commit approved.
The PR was not merged because it remains a draft. GitHub also currently reports no CI/check runs for this head. @aryansk, please mark the PR ready for review when ready; the existing claimed implementation remains authoritative for #2. |
|
Thanks for the detailed re-review and approval. I’ve marked the existing PR ready for review as requested. The authoritative head remains |
CI trigger noteThe PR was marked ready after its latest commit, but this repository’s current workflow does not include the |
MergedThank you, @aryansk. The approved head
|
|
Confirmed on my side: the approved head |
Summary
Add a consolidated, linked field reference for CiteSeal's
tweet.json, agent-bundle, and manifest data surfaces.Type of change
Changes
docs/schema-reference.mdwith required, optional, and nested fields for all three versioned surfaces.tweet.jsonvalidator.Testing
python tools/citeseal.py lintpasses (no new pyflakes issues)python tools/scripts/tweet_validate.py tests/fixtures/...passespython -m pytest tests/passes (242 passed)Manual testing details:
The documentation was checked against the schema files and validator source; no runtime behavior changed.
Checklist
tweet.jsonfields, I updated the schema and validation accordingly. (Not applicable: no fields changed.)Closes #2