fix(release-notes): stop printing the origin remote when it is refused - #21
Merged
Conversation
The refusal path for a non-GitHub origin echoed the whole remote URL. A remote carrying credentials in the URL puts them on the terminal, and in a log wherever the composer runs unattended. The message now names the problem without the value.
There was a problem hiding this comment.
Pull request overview
This PR hardens the scripts/release-notes.sh helper by avoiding printing the origin remote URL when it’s not a GitHub URL, preventing accidental credential leakage to terminals and logs during the refusal path.
Changes:
- Stop echoing the full
originremote URL in the “non-GitHub origin” failure message. - Keep existing GitHub-origin parsing behavior unchanged while making the refusal message value-free.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The refusal path for a non-GitHub origin echoed the whole remote URL. A remote that carries credentials in the URL puts them on the terminal, and into a log wherever the composer runs unattended. The message now names the problem without the value.
The four repositories carrying this script keep byte-identical copies, so the change lands in all of them together.
Validation
scripts/release-notes.test.sh passes 12/12, unchanged from main. No test asserts the refusal text, so nothing was silently dropped. The file is byte-identical to the copies in the sibling repositories.