v2 · Feature 4 — Media Types for Schemas - #4
Closed
robrigo wants to merge 3 commits into
Closed
Conversation
There was a problem hiding this comment.
Pull request overview
Adds schema “media type / descriptor” metadata by introducing a per-collection schematypes table and an action to set/update schema attribute type metadata, supporting AtomicAssets v2 schema extensions.
Changes:
- Introduces
FORMAT_TYPE(name + mediatype + info) for annotating schema attributes. - Adds
setschematypaction to validate and store schema type metadata keyed byschema_name. - Adds
schematypesmulti_index table and aget_schema_typesaccessor.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
src/atomicassets.cpp |
Implements setschematyp action validation + adds get_schema_types accessor implementation. |
include/atomicdata.hpp |
Adds FORMAT_TYPE struct definition used for schema media-type/descriptor metadata. |
include/atomicassets.hpp |
Exposes the new action, table (schematypes), and get_schema_types accessor in the contract interface. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| * Emplaces or modifies a schematype for a schema | ||
| * Can be used as a descriptor of a schema attribute (i.e. "Rarity"::"Provides X bonuses to this NFT") | ||
| * Can also be used as a media type for a schema attribute (i.e. denoting an IPFS hash with a particular file type, like .obj or .gltf for 3D files) | ||
| * Must match the formating of the schema |
| vector <FORMAT> schema_format_extension | ||
| ); | ||
|
|
||
| ACTION setschematyp( |
Comment on lines
+97
to
+100
| name authorized_creator, | ||
| name collection_name, | ||
| name schema_name, | ||
| vector <FORMAT_TYPE> schema_format_type |
| uint64_t primary_key() const { return schema_name.value; } | ||
| }; | ||
|
|
||
| typedef multi_index <name("schematypes"), schema_types_s> schema_types_t; |
|
|
||
| // Check to see if all elements in schema_format_type have unique names && exist within the schema_format | ||
| std::set<std::string> format_type_set; | ||
| for (FORMAT_TYPE & format_type_itr : schema_format_type){ |
Contributor
Author
|
Superseded by #9, which is merged. This feature is on |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds media-type support to schemas.
Mirrored into the canonical
atomicassetsorg for the AtomicAssets v2 release + audit.Original: wax-office-of-inspector-general/atomicassets-contract#5
masteryet. Kept on a feature branch to avoid prod integration risk; pending the comprehensive v2 audit.