ci: add VeRT test workflow to master (harness-guarded, gates PRs/pushes) - #17
Merged
Conversation
Adds the contract CI workflow to master so pushes + PRs into master are gated. master has no test harness yet (it arrives with v2), so the workflow's harness guard skips cleanly here (green no-op) and runs the full @vaulta/vert suite once v2 lands. Identical to the copy added to feat/v2-integration (PR #16) → no conflict when v2 merges to master. Runs on ubuntu-latest with the public CDT 4.1.1 .deb; actions SHA-pinned.
There was a problem hiding this comment.
Pull request overview
Adds a GitHub Actions workflow on master to build the contract (when the v2 harness is present) and run the @vaulta/vert (VeRT) test suite, while cleanly skipping on refs that don’t yet include the test harness.
Changes:
- Introduces
.github/workflows/contracts-ci.yamlto run on pushes and PRs, with a harness guard that no-ops on currentmaster. - Installs pinned CDT
4.1.1, sets up Node, installs JS deps, builds viamake build, and runsnpx jest --ciwhen the harness is present.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+10
to
+14
| on: | ||
| push: | ||
| branches: [master, feat/v2-integration, feat/v2-tests-integration, "ci/**"] | ||
| pull_request: | ||
| workflow_dispatch: |
Contributor
Author
There was a problem hiding this comment.
Already addressed in cbbba7f: pull_request now carries the same branches: filter as push (master, feat/v2-integration, feat/v2-tests-integration), so it no longer fires for PRs into other bases. push additionally keeps ci/** so workflow changes can be exercised on their own branch.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds the contract CI workflow to
masterso pushes and PRs into the default branch are gated by the@vaulta/verttest suite.masterhas no test harness yet (it arrives with v2:Makefile/package.json/tests/), so the workflow's harness guard skips cleanly here — a green no-op — and runs the full suite automatically once v2 lands onmaster. This also gates the openfeat/v2-* → masterPRs (#9/#10/#11), whose merge ref does contain the harness.The file is identical to the copy added to
feat/v2-integration(PR #16), so there's no conflict when v2 later merges tomaster.Validated
Pushed this branch (
ci/**push trigger) → run green in 7s, correctly skipped: "No contract test harness on this ref — skipping build + tests." Run: https://github.com/atomicassets/atomicassets-contract/actions/runs/27156991385See PR #16 for the full green run (build + 320 tests) on the v2 line where the harness is present.
Workflow
ubuntu-latest, harness-guarded; installs public CDT 4.1.1.deb,make build,npx jest. GitHub-hosted (the FACINGS monorepo's self-hosted + private-GHCR CI isn't reachable from this public org). Actions SHA-pinned.