v2 · Feature 1 — Reduce Max Template Supply - #1
Closed
robrigo wants to merge 3 commits into
Closed
Conversation
There was a problem hiding this comment.
Pull request overview
This PR introduces a new contract action to reduce a template’s max_supply, allowing authorized collection editors to lower the remaining mintable supply for an existing template as part of the AtomicAssets v2 feature set.
Changes:
- Added
redtemplmaxaction to reduce a template’smax_supplywhile ensuring it cannot go belowissued_supply. - Exposed the new action in the contract header so it becomes part of the contract’s public API/ABI.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
src/atomicassets.cpp |
Implements redtemplmax action logic and template table mutation. |
include/atomicassets.hpp |
Declares the new redtemplmax action in the contract interface. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+518
to
+521
| require_auth(authorized_editor); | ||
|
|
||
| auto collection_itr = collections.require_find(collection_name.value, | ||
| "No collection with this name exists"); |
Contributor
Author
|
Superseded by #9, which is merged. This feature is on |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reduces maximum template supply.
Mirrored into the canonical
atomicassetsorg for the AtomicAssets v2 release + audit.Original: wax-office-of-inspector-general/atomicassets-contract#3
masteryet. Kept on a feature branch to avoid prod integration risk; pending the comprehensive v2 audit.