ci: run checks on PRs targeting feat/** integration branches - #85
Merged
Conversation
CI previously only triggered on PRs to main, so PRs into feat/atomicassets-v2 ran zero checks and verification had to happen locally (bit us during the rentals descope: #84 merged with no CI).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CI only triggers on PRs to
main, so PRs into long-lived integration branches likefeat/atomicassets-v2run zero checks; every such PR (most recently #84, the rentals descope) had to be verified locally.One-line fix: add
feat/**to thepull_requesttrigger. Push-event coverage stays main-only, so nothing changes for regular branch pushes; only PRs into integration branches gain the standard lint/typecheck/build/test run.