Preserve validation errors for Unicode property paths - #274
Open
winklemad wants to merge 1 commit into
Open
Conversation
|
Hooray! All contributors have signed the CLA. |
🦋 Changeset detectedLatest commit: a9a0519 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
instancePathvalues contain Unicode property names.makeTreepath tokenization without decoding JSON Pointer tokens, so encoded~0and~1segments remain intact and numeric array-index grouping remains unchanged.Testing
pnpm exec vitest run src/__tests__/helpers/make-tree.js src/__tests__/index.js -t 'preserves escaped and Unicode JSON pointer segments|should output errors for Unicode property paths'— passed (2 tests).pnpm run test-ci -- --run— the new Unicode test and allmakeTreetests passed; the full run reported 16 ANSI-color snapshot mismatches outside the new assertions in the local Node 22/no-color environment.pnpm run lint— passed.pnpm exec prettier --check src/helpers.js src/__tests__/helpers/make-tree.js src/__tests__/index.js .changeset/tidy-pointers-smile.md— passed.