chore: require Node.js 24#644
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Aligns this package’s declared Node.js runtime requirement with an existing dependency constraint (homey-api now requiring Node.js 24), and centralizes the Node version used by CI into a single .nvmrc file.
Changes:
- Bump
package.jsonengines.nodefrom>=22to>=24. - Add
.nvmrcset to24. - Update all GitHub Actions workflows to use
actions/setup-nodewithnode-version-file: '.nvmrc'instead of hardcoded versions.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| package.json | Raises the declared Node engine requirement to >=24. |
| .nvmrc | Introduces a shared Node version reference for local dev + CI. |
| .github/workflows/update-homey-lib.yml | Switches Node setup to read from .nvmrc. |
| .github/workflows/test.yml | Switches Node setup to read from .nvmrc. |
| .github/workflows/publish-package-npm.yml | Switches Node setup to read from .nvmrc. |
| .github/workflows/npm-version.yml | Switches Node setup to read from .nvmrc. |
| .github/workflows/lint.yml | Switches Node setup to read from .nvmrc. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
homey-api@3.17.7 declares engines.node >=24, so the effective runtime floor is Node 24 even though package.json still said >=22. Bump engines.node to >=24 and add an .nvmrc pinned to 24 as the single source of truth. CI workflows now read the version via node-version-file: .nvmrc instead of hardcoding it.
RobinBol
force-pushed
the
chore/require-node-24
branch
from
8497ac8 to
e513450
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps the required Node.js version to 24 and introduces an
.nvmrcas the single source of truth.homey-api@3.17.7(a direct dependency) declaresengines.node: ">=24", so the effective runtime floor was already Node 24, while this package's ownengines.nodestill said>=22. This aligns the declared requirement with reality.Changes:
package.jsonengines.node:>=22->>=24.nvmrcpinned to24node-version-file: '.nvmrc'instead of a hardcoded version, so the version lives in one place