Skip to content

chore: remove .npmrc#60

Closed
RobinBol wants to merge 1 commit into
masterfrom
chore/remove-npmrc
Closed

chore: remove .npmrc#60
RobinBol wants to merge 1 commit into
masterfrom
chore/remove-npmrc

Conversation

@RobinBol

@RobinBol RobinBol commented May 18, 2026

Copy link
Copy Markdown
Contributor

Closed - superseded by automation. Kept open initially as a manual pre-clean for the upcoming @athombv/jsdoc-template migration to npmjs.org (athombv/jsdoc-template#23), then closed because:

  1. Merging this alone breaks npm ci here. package-lock.json still resolves @athombv/jsdoc-template via https://npm.pkg.github.com/...; without the .npmrc token mapping npm ci would 401 on install.
  2. The update-dependents.yaml workflow in chore: publish to npmjs.org via OIDC jsdoc-template#23 does the full transition in one commit per dependent: bumps the version, strips the @athombv / npm.pkg.github.com lines from .npmrc (and removes the file when empty), and regenerates package-lock.json so it resolves from npmjs.org.

The automated PR will appear here automatically after athombv/jsdoc-template#23 lands and the first npmjs.org publish runs.

@athombv/jsdoc-template is moving to npmjs.org, where it resolves from
the default registry without any scope mapping. This is the only
@athombv/* dependency in this repo, so dropping the file is safe.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Removes the repository-level npm configuration for the @athombv scope as preparation for installing @athombv/jsdoc-template from npmjs.org instead of GitHub Packages.

Changes:

  • Deletes the @athombv GitHub Packages registry mapping.
  • Deletes the GitHub Packages auth token configuration.
Comments suppressed due to low confidence (1)

.npmrc:1

  • Removing the GitHub Packages registry/auth mapping is incomplete while package-lock.json still resolves @athombv/jsdoc-template to https://npm.pkg.github.com/.... npm ci honors the lockfile URL, so installs can continue to hit GitHub Packages and fail without NODE_AUTH_TOKEN; regenerate/update the lockfile after the npmjs.org publish so it resolves through the public registry before dropping this file.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@RobinBol

Copy link
Copy Markdown
Contributor Author

Closing in favor of the automated update-dependents PR that will land here after athombv/jsdoc-template#23 merges and the first npmjs.org publish runs. That PR bumps the @athombv/jsdoc-template version, strips this .npmrc, and regenerates the lockfile in a single commit - which is necessary because the current lockfile still resolves @athombv/jsdoc-template via npm.pkg.github.com URLs. Removing .npmrc on its own would break npm ci here until the lockfile is updated.

@RobinBol RobinBol closed this May 18, 2026
@RobinBol RobinBol deleted the chore/remove-npmrc branch May 18, 2026 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants