Skip to content

fix(scripts): three comments and one guard that cite mechanisms not on main #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
atbrace merged 1 commit into from
Aug 1, 2026
Merged

fix(scripts): three comments and one guard that cite mechanisms not on main #4

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion scripts/check-core-boundary.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,7 +135,17 @@ COMMERCIAL_SURFACE="internal/cliauth internal/serviceproto cmd/gc/cmd_login.go"
COMMERCIAL_FIELD_RE='json:"[^"]*(trial|billing|credit|plan|invoice|subscription|quota|coupon|entitlement)'
commercial_fields=""
for p in $COMMERCIAL_SURFACE; do
[ -e "$p" ] || continue
# A surface member that has not landed yet is skipped, but never SILENTLY:
# this file's contract is fail-closed (see header), and an unannounced skip
# is how a guard stays switched off after the package it guards arrives.
# internal/serviceproto is the current expected absence — it is planned for
# this module, not the hosted one (engdocs/plans/hosted-onboarding/DESIGN.md).
# If a name here is still reported once its package exists, the path is wrong
# and check (f) is scanning nothing.
if [ ! -e "$p" ]; then
note "(f) surface member not present, not scanned: $p"
continue
fi
hits=$(grep -rnE --include='*.go' "$COMMERCIAL_FIELD_RE" "$p" 2>/dev/null \
| grep -v '_test\.go:' | grep -v 'boundary:allow commercial')
if [ -n "$hits" ]; then
Expand Down
8 changes: 5 additions & 3 deletions scripts/gc-session-docker
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
# GC_SESSION=exec:scripts/gc-session-docker gc start
#
# Implements the Gas City exec session provider protocol (see
# internal/session/exec/exec.go). Each agent runs in its own Docker
# docs/reference/exec-session-provider.md). Each agent runs in its own Docker
# container with tmux providing session management inside the container.
#
# Architecture:
Expand Down Expand Up @@ -41,8 +41,10 @@ TMUX_SOCK_DIR="/run/gc-tmux"

# Controller-only env vars stripped from containers. These reference
# controller-side resources (Unix sockets, localhost ports) that aren't
# reachable from inside a container. Matches the K8s provider's skip list
# in internal/session/k8s/pod.go buildPodEnv().
# reachable from inside a container. This list is maintained here and is not
# derived from any other provider — contrib/session-scripts/gc-session-k8s
# carries no equivalent list, so add a var here when it names a
# controller-local coordinate, without expecting a canonical copy elsewhere.
# Strip controller-only connection coordinates; auth credentials
# (GC_DOLT_USER, GC_DOLT_PASSWORD, BEADS_DOLT_SERVER_USER, BEADS_DOLT_PASSWORD)
# pass through — agents need them to authenticate against Dolt.
Expand Down
Loading