close-prs-for-unapproved-issues workflow does not close PRs linked to pre-existing issues

[batchu5]

Describe the bug.

The three issue-approval workflows (issue-awaiting-approval.yml, issue-approve-command.yml, close-prs-for-unapproved-issues.yml) were all introduced in PR #2192. The auto-labelling workflow (issue-awaiting-approval.yml) only fires on issues: opened, so any issue created before that date never received the Awaiting Approval label.

The PR-closing workflow checks whether the linked issue has the Awaiting Approval label (line 76):

For pre-existing issues that have neither Awaiting Approval nor Approved Issue, this condition is false, so the PR stays open - bypassing the intended gate.

Proposed fix
Rather than checking if Awaiting Approval is present, we will check if the issue has the Approved Issue label. If yes, it keeps the pr open other wise closes that pr

Expected behavior

New PR's, which are linked to old issues, are closed even if the awaiting approval label is not there!

Screenshots

This pr is not closed, even though attached issue is not approved !!

How to Reproduce

see the screenshot i have attached!

🖥️ Device Information [optional]

No response

👀 Have you checked for similar open issues?

• I checked and didn't find similar issue

🏢 Have you read the Contributing Guidelines?

• I have read the Contributing Guidelines

Are you willing to work on this issue ?

Yes I am willing to submit a PR!

[Yashisinghal285]

Hi, I'd like to work on this issue. I can update the close-prs-for-unapproved-issues.yml workflow so that PRs linked to issues are kept open only when the issue has the Approved Issue label, including pre-existing issues. I’ll also verify the workflow behavior and add/update tests if applicable.

[batchu5]

sure! you can work on it

[Yashisinghal285]

Hi @derberg @Adi-204, could one of the maintainers please review and approve this issue with /approve? I have the PR ready and all checks are passing. Thanks!

[batchu5]

Hey @Yashisinghal285, for this pr we are not gonna use the /approve command. We are checking some workarounds for this workflow. So be patient; Derberg will reopen the pr soon!! cheers

[Yashisinghal285]

Thanks for the update @batchu5! Sounds great, I'll wait for @derberg to reopen it.