allow json values containing colon - fixes #62#69
Open
grmble wants to merge 1 commit into
Open
Conversation
e.g q=cm:creator=UserName
|
does #70 also resolve your issue? |
Author
|
@dch I don't think so - #70 just tries raw json before headers and params (in the context of wanting to use params with a colon - I am aware that it actually does more than that) My problem is that headers are tried before params, and a param containing a colon will be interpreted as a (faulty) header. Simply changing the order so params are checked before headers does not work either, that would break headers containing an equal sign. Which is what #59 fixed ... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I need to post JSON containing Lucene queries, that tends to contain colons. E.g. q=cm:title:foo
That did not work though, bat tries to parse it as a header and then complains about the equal sign.
There is an issue open for this: #62
I don't much like this solution, I think the function is too compliated as is. But I could not come up with anything simpler, and I've been using this for a week now.