fix: prevent Tapwrite IndexSizeError when syncing content while focused - #1442
Draft
cursor[bot] wants to merge 1 commit into
Draft
fix: prevent Tapwrite IndexSizeError when syncing content while focused#1442cursor[bot] wants to merge 1 commit into
cursor[bot] wants to merge 1 commit into
Conversation
Fixes TASKS-A5 When a realtime update changes task body while the Tapwrite editor still has focus, Tapwrite calls setContent and ProseMirror tries to reconcile a stale DOM selection, causing IndexSizeError on collapse. Gate external content updates on editor focus state in TaskEditor and TemplateDetails. Co-authored-by: Neil Raina <makeitraina@users.noreply.github.com>
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
contentprop updates on editor focus state inTaskEditorandTemplateDetailsonFocus/onBlurso realtime/redux body updates do not call TapwritesetContentwhile the user still has the editor focusedFixes TASKS-A5 / OUT-4157
Testing Criteria
setContentwhile editor focused)contentsync behavior intapwrite@1.2.0IndexSizeError; after blur, external content should syncNotes
isUserTypingguard was insufficient because typing can stop while focus remains in the editorImpact & Surface Area of Change
TaskEditor)TemplateDetails)