Skip to content

OUT-4109 | Handle SWR mutate rejections instead of letting them reach Sentry #1439

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
priosshrsth merged 5 commits into from
Aug 27, 2026
Merged

OUT-4109 | Handle SWR mutate rejections instead of letting them reach Sentry #1439

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
8f63a1b
OUT-4027 | Fix 500 when deleting a task whose label row is missing (#…
priosshrsth Aug 7, 2026
1327cf7
OUT-4093 | Stop reading localStorage in the assignee cache (#1434)
priosshrsth Aug 24, 2026
9806fe8
Merge branch 'production' into main
priosshrsth Aug 24, 2026
92b312f
OUT-4109 | Handle SWR mutate rejections instead of letting them reach…
priosshrsth Aug 26, 2026
e4a0c49
Merge branch 'main' of github.com:assemblycom/tasks-app into anit/out…
priosshrsth Aug 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions src/app/configure-tasks-app/ui/Subtemplates.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,8 @@

const { mutate } = useSWRConfig()

const _debounceMutate = async (cacheKey: string) => await mutate(cacheKey)
const _debounceMutate = (cacheKey: string) =>
mutate(cacheKey).catch((error) => console.error('Failed to revalidate subtemplates:', error))
const debounceMutate = useDebounce(_debounceMutate, 200)

useEffect(() => {
Expand All @@ -66,9 +67,9 @@
}

debounceMutate(cacheKey)
}, [activeTemplate?.subTaskTemplates])

Check warning on line 70 in src/app/configure-tasks-app/ui/Subtemplates.tsx

View workflow job for this annotation

GitHub Actions / Run linters and tests 

React Hook useEffect has missing dependencies: 'activeTemplate', 'cacheKey', and 'debounceMutate'. Either include them or remove the dependency array

const handleSubtemplateCreation = (payload: CreateTemplateRequest) => {
const handleSubtemplateCreation = async (payload: CreateTemplateRequest) => {
const tempId = generateRandomString('temp-template')
setOptimisticUpdates((prev) => [
...prev,
Expand All @@ -90,7 +91,7 @@
const optimisticData = sortTaskByDescendingOrder([...currentSubtemplates, tempSubtemplate])

try {
mutate(
await mutate(
cacheKey,
async () => {
const subTask = await createSubTemplate(token, template_id, payload)
Expand Down
5 changes: 3 additions & 2 deletions src/app/detail/ui/ActivityWrapper.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,8 @@

useScrollToElement('commentId')

const _debounceMutate = async (cacheKey: string) => await mutate(cacheKey)
const _debounceMutate = (cacheKey: string) =>
mutate(cacheKey).catch((error) => console.error('Failed to revalidate activity logs:', error))
const debounceMutate = useDebounce(_debounceMutate, 300)

const shouldRefetchRef = useRef(true) //preventing double fetching from comment apis. Due to optimistic update revalidation, we are already fetching logs there. So no need to refetch in case for comment creation and deletion.
Expand All @@ -77,7 +78,7 @@
}
setLastUpdated(task?.lastActivityLogUpdated)
}
}, [task?.lastActivityLogUpdated])

Check warning on line 81 in src/app/detail/ui/ActivityWrapper.tsx

View workflow job for this annotation

GitHub Actions / Run linters and tests 

React Hook useEffect has missing dependencies: 'cacheKey', 'debounceMutate', 'lastUpdated', and 'task'. Either include them or remove the dependency array

const currentUserId = tokenPayload.internalUserId ?? tokenPayload.clientId

Expand All @@ -102,7 +103,7 @@
const optimisticData = getOptimisticData(postCommentPayload, activities.data, tempLog)

try {
mutate(
await mutate(
cacheKey,
async () => {
shouldRefetchRef.current = false
Expand Down
7 changes: 4 additions & 3 deletions src/app/detail/ui/Subtasks.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,8 @@

const { mutate } = useSWRConfig()

const _debounceMutate = async (cacheKey: string) => await mutate(cacheKey)
const _debounceMutate = (cacheKey: string) =>
mutate(cacheKey).catch((error) => console.error('Failed to revalidate subtasks:', error))
const debounceMutate = useDebounce(_debounceMutate, 200)

useEffect(() => {
Expand All @@ -82,9 +83,9 @@
debounceMutate(cacheKey)
}
setLastUpdated(activeTask?.lastSubtaskUpdated)
}, [activeTask?.lastSubtaskUpdated])

Check warning on line 86 in src/app/detail/ui/Subtasks.tsx

View workflow job for this annotation

GitHub Actions / Run linters and tests 

React Hook useEffect has missing dependencies: 'activeTask', 'cacheKey', 'debounceMutate', and 'lastUpdated'. Either include them or remove the dependency array

const handleSubTaskCreation = (payload: CreateTaskRequest) => {
const handleSubTaskCreation = async (payload: CreateTaskRequest) => {
const tempId = generateRandomString('temp-task')
setOptimisticUpdates((prev) => [
...prev,
Expand All @@ -104,7 +105,7 @@
)
const optimisticData = subTasks?.tasks ? sortSubtasksByPriority([...subTasks.tasks, tempSubtask]) : [tempSubtask]
try {
mutate(
await mutate(
cacheKey,
async () => {
const subTask = await handleCreate(token, payload, { disableSubtaskTemplates: true })
Expand Down
Loading