fix(POR-22636): resolve null comment initiatorType in public API responses - #1408
Draft
cursor[bot] wants to merge 2 commits into
Draft
fix(POR-22636): resolve null comment initiatorType in public API responses#1408cursor[bot] wants to merge 2 commits into
cursor[bot] wants to merge 2 commits into
Conversation
…1397) deleteLabel passed `id: currentLabel?.id` straight into label.delete, so when findFirst matched nothing Prisma got `{ id: undefined }` and threw PrismaClientValidationError, failing the whole delete transaction. Return early instead.
…onses Legacy comments can have null initiatorType in the database. The public comment serializer was passing this through as createdByUserType: null, which the Copilot platform rejects with 'required field createdByUserType is nil'. Resolve initiator type from workspace user lists (with API fallback) before serializing public comments and comment.created webhooks. Co-authored-by: Neil Raina <makeitraina@users.noreply.github.com>
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
SandipBajracharya
force-pushed
the
main
branch
from
August 26, 2026 13:11
1bc04dd to
51d44fd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
CommentService.resolveCommentInitiatorTypes()to inferinitiatorTypefor legacy comments with null valuescomment.createdwebhookscreatedByUserTypeanduploadedByUserTyperequired (non-null) in public DTOsTesting Criteria
resolveCommentInitiatorTypescovering: already-set type, IU list resolution, client list resolution, and API fallback when not in bulk listsyarn test src/app/api/comments/comment.service.resolve-initiator-type.test.ts— all 4 tests passNotes
initiatorType: nullin DB (added as optional in migration20250227112916). Public API was returningcreatedByUserType: null, which the Copilot platform rejects.yarn cmd:backfill-initiatorType-in-commentsto persist resolved types in DB for remaining legacy rows.Impact & Surface Area of Change
GET/DELETE /api/comments/public)comment.createdwebhook payloads