POR-22617: Retry client list pagination when Copilot cursor is invalid - #1406
Draft
cursor[bot] wants to merge 2 commits into
Draft
POR-22617: Retry client list pagination when Copilot cursor is invalid#1406cursor[bot] wants to merge 2 commits into
cursor[bot] wants to merge 2 commits into
Conversation
…1397) deleteLabel passed `id: currentLabel?.id` straight into label.delete, so when findFirst matched nothing Prisma got `{ id: undefined }` and threw PrismaClientValidationError, failing the whole delete transaction. Return early instead.
When fetching large client lists (>5000), CopilotAPI paginates via nextToken. DynamoDB can reject a stale or invalidated cursor with ValidationException (starting key is invalid), which surfaces in Tasks Sentry during assignee load. Retry once without the stale token for single-page requests, and restart batched pagination from the first page when a later-page cursor fails. Co-authored-by: Neil Raina <makeitraina@users.noreply.github.com>
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
SandipBajracharya
force-pushed
the
main
branch
from
August 26, 2026 13:11
1bc04dd to
51d44fd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
CopilotAPI#getClientswhen the Assembly/Copilot API returns a DynamoDBValidationExceptionfor an invalid pagination cursor (starting key is invalid).nextTokenand retry once.Testing Criteria
yarn test src/utils/copilotError.test.ts src/utils/CopilotAPI.getClients.test.ts— all 4 tests pass.nextTokenand invalid mid-pagination cursor.Notes
MAX_FETCH_ASSIGNEE_COUNT= 15,000) paginate clients in 5,000-item batches; Copilot/DynamoDB can invalidate cursors between pages or when a stale token is reused.Impact & Surface Area of Change
CopilotAPI#getClientsonly — used by assignee loading (/api/users), activity logs, subtasks, notifications, and backfill scripts.