POR-22607: Retry attachment uploads and filter transient S3 network Sentry noise - #1405
Draft
cursor[bot] wants to merge 2 commits into
Draft
POR-22607: Retry attachment uploads and filter transient S3 network Sentry noise#1405cursor[bot] wants to merge 2 commits into
cursor[bot] wants to merge 2 commits into
Conversation
…1397) deleteLabel passed `id: currentLabel?.id` straight into label.delete, so when findFirst matched nothing Prisma got `{ id: undefined }` and threw PrismaClientValidationError, failing the whole delete transaction. Return early instead.
…entry noise Add up to 3 attempts in uploadAttachmentHandler for signed-url fetch and Supabase storage PUT failures. Filter client-side Sentry noise for transient RequestError/send-request-failed patterns during image uploads. Co-authored-by: Neil Raina <makeitraina@users.noreply.github.com>
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
SandipBajracharya
force-pushed
the
main
branch
from
August 26, 2026 13:11
1bc04dd to
51d44fd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
uploadAttachmentHandlerfor signed-url fetch and Supabase storage upload failures (restores the retry behavior previously present in the removedinlineImage.tshelper).ignoreErrorspatterns for transient storage upload network failures (RequestError: send request failed,S3 image upload failed).Testing Criteria
yarn lint:check— passes.Notes
RequestError: send request failedmessage is a low-level transport error (VPN/proxy blip, DNS/TLS hiccup, ad blocker, or brief storage endpoint unreachability), not a tasks-app business-logic bug.Impact & Surface Area of Change