OUT-4085 | Treat suppressed reminder emails as deduped no-ops - #1403
Closed
cursor[bot] wants to merge 2 commits into
Closed
OUT-4085 | Treat suppressed reminder emails as deduped no-ops#1403cursor[bot] wants to merge 2 commits into
cursor[bot] wants to merge 2 commits into
Conversation
…1397) deleteLabel passed `id: currentLabel?.id` straight into label.delete, so when findFirst matched nothing Prisma got `{ id: undefined }` and threw PrismaClientValidationError, failing the whole delete transaction. Return early instead.
When Copilot createNotification returns null (platform suppressed the email), grouped and single reminder dispatch jobs previously threw, retried three times, deleted TaskReminderSent ledger rows on failure, and re-enqueued on the next cron — causing recurring Sentry noise for recipients who cannot receive email. Return null from send*ReminderEmail helpers, log a warning, and succeed the dispatch run while keeping ledger rows for dedupe. Co-authored-by: Neil Raina <makeitraina@users.noreply.github.com>
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
SandipBajracharya
force-pushed
the
main
branch
from
August 26, 2026 13:11
1bc04dd to
51d44fd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
createNotificationreturns null for grouped or single task reminder emails, log a warning and return success from the dispatch job instead of throwing.TaskReminderSentledger rows on platform suppression so the daily cron does not re-enqueue the same reminders indefinitely.sendGroupedReminderEmailandsendReminderEmailfor consistency.Testing Criteria
yarn test src/jobs/notifications/send-grouped-reminder-email.test.ts src/jobs/notifications/dispatch-grouped-reminder-email.test.ts src/jobs/notifications/send-reminder-email.test.ts src/jobs/notifications/dispatch-reminder-email.test.ts --runInBand(24 tests passed)Notes
sendGroupedReminderEmail: notification was unexpectedly suppressedImpact & Surface Area of Change
dispatch-grouped-reminder-email,dispatch-reminder-emailsend-grouped-reminder-email,send-reminder-email