Gracefully skip notifications when company has no clients for message channel - #1401
Closed
cursor[bot] wants to merge 1 commit into
Closed
Gracefully skip notifications when company has no clients for message channel#1401cursor[bot] wants to merge 1 commit into
cursor[bot] wants to merge 1 commit into
Conversation
Skip in-product notification dispatch when the platform reports a company has no client users for message channel creation, and avoid fan-out when company task notifications have zero recipients. Co-authored-by: Neil Raina <makeitraina@users.noreply.github.com>
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Handles a Copilot platform
not_foundresponse when creating in-product notifications for company-assigned tasks whose company has no client users (message channel cannot be created). This error was surfacing in Sentry as production noise from tasks-app notification paths.Changes
isNoCompanyClientsMessageChannelErrorhelper incopilotError.ts(mirrors existing senderCompanyId handling).recipientIdsis empty increateBulkNotificationand company task assignment flow.NotificationService, grouped-email jobs, reply notifications, and validate-count backfill.Manual verification
yarn test src/utils/copilotError.test.ts src/app/api/notification/notification.service.test.ts— all passing.Linear
POR-22481