Handle expected Prisma API errors without Sentry noise - #1364
Closed
cursor[bot] wants to merge 1 commit into
Closed
Conversation
Co-authored-by: Neil Raina <makeitraina@users.noreply.github.com>
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
P2025not-found andP2023malformed-ID/column-data failures as handled 404 responses withoutconsole.error.Testing Criteria
yarn test src/app/api/tests/utils/withErrorHandler.test.ts --runInBand— 8/8 tests passed, including no-log assertions for API/Zod/Copilot/P2025/P2023 and log assertions for unclassified Prisma/unexpected errors.yarn prettier:check— passed.yarn lint:check— passed with existing React hook/compiler warnings only.yarn test --runInBand— 16/17 suites passed; the remainingsrc/app/api/tests/utils/authenticate.test.tssuite fails before tests run on the existing Jest/p-retry ESM parse issue (SyntaxError: Cannot use import statement outside a modulefromnode_modules/p-retry/index.js).yarn tsc— still fails on the repo's pre-existing SVG module declaration errors fromsrc/icons/index.ts; no type errors from this change were reported before that baseline failure.Notes
PrismaClientKnownRequestError:). Linear and Sentry MCP servers require authentication in this automation environment, so direct event/project metadata and Linear ticket commenting were unavailable from the agent.withErrorHandlerwas logging before classifying errors, so expected API-boundary Prisma failures (e.g. missing row or malformed UUID route params) could emitconsole.errorand create Sentry noise even though the API returned a handled JSON response.Impact & Surface Area of Change
withErrorHandler.console.errorcalls.