Skip to content

OUT-3920 | Add the +N other tasks on the bullet point - #1353

Merged
arpandhakal merged 1 commit into
feature/grouped-emailsfrom
OUT-3920-add-overflow-bullet-point
Jun 29, 2026
Merged

arpandhakal merged 1 commit into
feature/grouped-emailsfrom
OUT-3920-add-overflow-bullet-point

Conversation

@arpandhakal

@arpandhakal arpandhakal commented Jun 29, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • Moves the +N other tasks overflow text from a bare <em>...<br> outside the <ul> into a <li> inside it, for both the normal grouped email and the grouped reminder email
  • Both renderers now produce identical HTML structure; the overflow item renders as a bullet point in line with the task list

Test plan

  • Both groupedEmail.renderer.test.ts and groupedReminderEmail.renderer.test.ts pass (28 tests)
  • Verify a grouped email with overflow visually shows +N other tasks as a bullet point, not as orphaned italic text below the list

🤖 Generated with Claude Code

…ist (OUT-3920)

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@linear-code

linear-code Bot commented Jun 29, 2026

Copy link
Copy Markdown

OUT-3920

@vercel

vercel Bot commented Jun 29, 2026

Copy link
Copy Markdown
Contributor

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
tasks-app Ready Ready Preview, Comment Jun 29, 2026 6:23am

Request Review

@greptile-apps

greptile-apps Bot commented Jun 29, 2026

Copy link
Copy Markdown

Greptile Summary

This PR moves the +N other tasks overflow indicator from an orphaned <em>...<br> element placed after </ul> into a proper <li> inside the list, in both groupedEmail.renderer.ts and groupedReminderEmail.renderer.ts. Tests in both test files are updated to match the new HTML structure.

  • Both renderers now produce <ul>...<li><em>+N other tasks</em></li></ul>, making the overflow bullet structurally consistent with the task list items.
  • The groupedReminderEmail test correctly updates the <li> count assertion from 3 to 4 to account for the overflow item now being a list element.

Confidence Score: 5/5

Safe to merge — the change is small, well-scoped, and both renderer/test pairs are in sync.

The only modification is moving the overflow element inside the <ul> and wrapping it in <li>; no logic around overflow calculation, pluralization, or truncation is touched. Both test files are updated to match and correctly account for the extra <li> in count assertions.

No files require special attention.

Important Files Changed

Filename Overview
src/app/api/notification/groupedEmail.renderer.ts Moves overflow item into the <ul> as a <li> element; rename from overflow to overflowItem matches the new structure. Change is minimal and correct.
src/app/api/notification/groupedReminderEmail.renderer.ts Identical structural change to overflow rendering as the grouped email renderer; consistent with the stated goal.
src/app/api/notification/groupedEmail.renderer.test.ts Test assertions updated from <em>+N other tasks</em><br> to <li><em>+N other tasks</em></li>; not.toContain guard for plural form also updated correctly.
src/app/api/notification/groupedReminderEmail.renderer.test.ts Correctly updates the <li> count from 3 to 4 and updates string assertions to the new <li>-wrapped format.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[renderSection / renderGroup] --> B{overflowCount > 0?}
    B -- Yes --> C["overflowItem = <li><em>+N other tasks</em></li>"]
    B -- No --> D["overflowItem = ''"]
    C --> E["<ul>${items}${overflowItem}</ul>"]
    D --> E
    E --> F[htmlBody section string]
Loading
%%{init: {'theme': 'base', 'themeVariables': {"darkMode": true, "background": "#0d1117", "primaryColor": "#21262d", "primaryTextColor": "#e6edf3", "primaryBorderColor": "#8b949e", "lineColor": "#8b949e", "textColor": "#e6edf3", "edgeLabelBackground": "#161b22", "actorBkg": "#21262d", "actorBorder": "#8b949e", "actorTextColor": "#e6edf3", "actorLineColor": "#8b949e", "signalColor": "#8b949e", "signalTextColor": "#e6edf3", "noteBkgColor": "#373320", "noteBorderColor": "#d4a72c", "noteTextColor": "#f0e6c0", "labelBoxBkgColor": "#21262d", "labelBoxBorderColor": "#8b949e", "labelTextColor": "#e6edf3", "loopTextColor": "#e6edf3", "activationBkgColor": "#30363d", "activationBorderColor": "#8b949e"}}}%%
flowchart TD
    A[renderSection / renderGroup] --> B{overflowCount > 0?}
    B -- Yes --> C["overflowItem = <li><em>+N other tasks</em></li>"]
    B -- No --> D["overflowItem = ''"]
    C --> E["<ul>${items}${overflowItem}</ul>"]
    D --> E
    E --> F[htmlBody section string]
Loading

Reviews (1): Last reviewed commit: "fix(notifications): render +N overflow a..." | Re-trigger Greptile

@priosshrsth priosshrsth left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. And I do think this is a better approach than before.

@arpandhakal
arpandhakal merged commit f1b5f27 into feature/grouped-emails Jun 29, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants