OUT-3920 | Add the +N other tasks on the bullet point - #1353
Conversation
…ist (OUT-3920) Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Greptile SummaryThis PR moves the
Confidence Score: 5/5Safe to merge — the change is small, well-scoped, and both renderer/test pairs are in sync. The only modification is moving the overflow element inside the No files require special attention. Important Files Changed
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart TD
A[renderSection / renderGroup] --> B{overflowCount > 0?}
B -- Yes --> C["overflowItem = <li><em>+N other tasks</em></li>"]
B -- No --> D["overflowItem = ''"]
C --> E["<ul>${items}${overflowItem}</ul>"]
D --> E
E --> F[htmlBody section string]
%%{init: {'theme': 'base', 'themeVariables': {"darkMode": true, "background": "#0d1117", "primaryColor": "#21262d", "primaryTextColor": "#e6edf3", "primaryBorderColor": "#8b949e", "lineColor": "#8b949e", "textColor": "#e6edf3", "edgeLabelBackground": "#161b22", "actorBkg": "#21262d", "actorBorder": "#8b949e", "actorTextColor": "#e6edf3", "actorLineColor": "#8b949e", "signalColor": "#8b949e", "signalTextColor": "#e6edf3", "noteBkgColor": "#373320", "noteBorderColor": "#d4a72c", "noteTextColor": "#f0e6c0", "labelBoxBkgColor": "#21262d", "labelBoxBorderColor": "#8b949e", "labelTextColor": "#e6edf3", "loopTextColor": "#e6edf3", "activationBkgColor": "#30363d", "activationBorderColor": "#8b949e"}}}%%
flowchart TD
A[renderSection / renderGroup] --> B{overflowCount > 0?}
B -- Yes --> C["overflowItem = <li><em>+N other tasks</em></li>"]
B -- No --> D["overflowItem = ''"]
C --> E["<ul>${items}${overflowItem}</ul>"]
D --> E
E --> F[htmlBody section string]
Reviews (1): Last reviewed commit: "fix(notifications): render +N overflow a..." | Re-trigger Greptile |
priosshrsth
left a comment
There was a problem hiding this comment.
lgtm. And I do think this is a better approach than before.
Summary
+N other tasksoverflow text from a bare<em>...<br>outside the<ul>into a<li>inside it, for both the normal grouped email and the grouped reminder emailTest plan
groupedEmail.renderer.test.tsandgroupedReminderEmail.renderer.test.tspass (28 tests)+N other tasksas a bullet point, not as orphaned italic text below the list🤖 Generated with Claude Code