Skip to content

OUT-2090 | OUT-2091 | OUT-2092: fixed the first time UI flow - #85

Merged
SandipBajracharya merged 8 commits into
previewfrom
OUT-2090
Jul 30, 2025
Merged

OUT-2090 | OUT-2091 | OUT-2092: fixed the first time UI flow#85
SandipBajracharya merged 8 commits into
previewfrom
OUT-2090

Conversation

@SandipBajracharya

Copy link
Copy Markdown
Collaborator

Changes

  • disable "Enable app" button until both settings have been confirmed
  • show "Confirm" button in initial load in invoice details setting. Once confirmed, show "Update settings".
  • only show "Cancel" button after updating the existing sync

Testing Criteria

Loom

SandipBajracharya and others added 5 commits July 9, 2025 13:13
Merge preview branch (staging) to main/master (production)
- [X] disable "Enable app" button until both settings have been confirmed
- [X] show "Confirm" button in initial load in invoice details setting. Once confirmed, show "Update settings".
- [X] only show "Cancel" button after updating the existing sync
@vercel

vercel Bot commented Jul 29, 2025

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
quickbooks-sync ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 30, 2025 10:37am
quickbooks-sync (dev) ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 30, 2025 10:37am

- [X] disable "Enable app" button until both settings have been confirmed
- [X] show "Confirm" button in initial load in invoice details setting. Once confirmed, show "Update settings".
- [X] only show "Cancel" button after updating the existing sync

@rrojan rrojan left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, apart from the minor code quality issue 🏆

Comment thread src/app/api/quickbooks/setting/setting.controller.ts Outdated
@SandipBajracharya
SandipBajracharya merged commit 51b76b3 into preview Jul 30, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants