Skip to content

OUT-2056: Initial "Connect to Quickbooks" screen - #81

Merged
SandipBajracharya merged 1 commit into
previewfrom
OUT-2056
Jul 24, 2025
Merged

OUT-2056: Initial "Connect to Quickbooks" screen#81
SandipBajracharya merged 1 commit into
previewfrom
OUT-2056

Conversation

@SandipBajracharya

Copy link
Copy Markdown
Collaborator

Changes

  • update initial connection screen with settings section and product mapping table
  • blurred and disabled setting section
  • issue fix: when sync fails, sync flag was not true after re-authorization
  • issue fix: when sync fails and re-authorization is done, the QB items in dropdown were not loaded.
  • only fetch QB items when sync flag is true. Added condition to not fetch QB items when:
    • sync fails
    • during initial page
  • "Connecting" label in callout button when initial connection and re-authorization

Testing Criteria

Loom

- [X] update initial connection screen with settings section and product mapping table
- [X] blurred and disabled setting section
- [X] issue fix: when sync fails, sync flag was not true after re-authorization
- [X] issue fix: when sync fails and re-authorization is done, the QB items in dropdown were not loaded.
- [X] only fetch QB items when sync flag is true. Added condition to not fetch QB items when:
	- sync fails
	- during initial page
- [X] "Connecting" label in callout button when initial connection and re-authorization
@linear

linear Bot commented Jul 23, 2025

Copy link
Copy Markdown

@SandipBajracharya SandipBajracharya changed the title update(OUT-2056): Initial "Connect to Quickbooks" screen OUT-2056: Initial "Connect to Quickbooks" screen Jul 23, 2025
@vercel

vercel Bot commented Jul 23, 2025

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
quickbooks-sync ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 23, 2025 11:53am

@rrojan rrojan left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screen.Recording.2025-07-24.at.14.50.39.mov

Since there is no sync with quickbooks going on when sync is not active, maybe we should consider changing the copy here to "Fetching Copilot Products" instead? Out of the scope of current ticket though.

@rrojan rrojan left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🏆
Great PR!

@SandipBajracharya
SandipBajracharya merged commit a5fa171 into preview Jul 24, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants