OUT-2310, OUT-2287, OUT-2246 | client home crashed with undefined on replaceAll - #105
Merged
Conversation
…e and contents. Added some checks before proceeding with event handlers too
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
rrojan
approved these changes
Sep 5, 2025
rrojan
left a comment
rrojan
left a comment
Contributor
There was a problem hiding this comment.
LGTM, apart from requested changes
Comment on lines
219
to
+220
| replaceCustomLabelsWithPlaceholders( | ||
| defaultState.replaceAll(' ', ''), | ||
| defaultState?.replaceAll(' ', ''), |
Contributor
There was a problem hiding this comment.
Does replaceCustomLabelsWithPlaceholders handle undefined as a first param? If not, we should default to an empty string:
Suggested change
| replaceCustomLabelsWithPlaceholders( | |
| defaultState.replaceAll(' ', ''), | |
| defaultState?.replaceAll(' ', ''), | |
| replaceCustomLabelsWithPlaceholders( | |
| defaultState?.replaceAll(' ', '') ?? '', |
Comment on lines
+42
to
+43
| item | ||
| .toLowerCase() |
Contributor
There was a problem hiding this comment.
Suggested change
| item | |
| .toLowerCase() | |
| item | |
| ?.toLowerCase() |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The main changes are