fix(OUT-4020): bump tiptap to 3.29.2 to fix RangeError in delete extension - #229
Merged
priosshrsth merged 1 commit intoAug 5, 2026
Conversation
…nsion @tiptap/core 3.20.0's built-in `delete` extension called `doc.nodeAt(newStart - 1)` without a bounds check, so a RemoveMarkStep mapping to position 0 threw `RangeError: Position -1 outside of fragment`. It runs inside a setTimeout, so nothing caught it. Upstream added the `newStart > 0` guard in 3.22.0. Bumped the whole @tiptap/* set rather than core alone: starter-kit's transitive extensions float on carets and would otherwise sit several minors ahead of a pinned core. No breaking changes across 3.20 -> 3.29. Fixes CLIENT-HOME-V3-1N Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Greptile SummaryThe PR upgrades the complete Tiptap dependency set from 3.20.0-era resolutions to 3.29.2 to incorporate the upstream delete-extension bounds check while retaining one consistent core/PM version.
Confidence Score: 5/5The PR appears safe to merge, with no concrete changed-code defect identified in the coordinated dependency upgrade. The manifest and lockfile resolve the Tiptap core, React integration, extensions, and ProseMirror bundle consistently at 3.29.2, and the investigated transitive changes do not establish a reachable compatibility failure on supported targets. Important Files Changed
Reviews (1): Last reviewed commit: "fix(OUT-4020): bump tiptap to 3.29.2 to ..." | Re-trigger Greptile |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the Sentry crash in OUT-4020 (CLIENT-HOME-V3-1N).
@tiptap/core3.20.0's built-indeleteextension calleddoc.nodeAt(newStart - 1)with no bounds check, so aRemoveMarkStepmapping to position 0 threwRangeError: Position -1 outside of fragment. It runs in asetTimeout, so nothing caught it. Upstream added thenewStart > 0guard in 3.22.0 — this is a dependency bump, no app code changed.What to look at
package.json/pnpm-lock.yaml— the whole@tiptap/*set moves 3.20.0 → 3.29.2, not core alone. starter-kit's transitive extensions float on carets, so pinning core alone would leave them several minors ahead of it. Tree now has a single@tiptap/core. Checked every release 3.20 → 3.29: no breaking changes.Verified / not verified
typecheck,lintandbuildpass; guard confirmed present in the installed dist. Not verified in a real portal — the Sentry event is a single occurrence with no repro steps and reproducing needs a live client session. Since this bumps the editor by 9 minors, the review risk is regression in the editor generally, not in the crash path: worth a pass over the portal and the editor (links/autolink, tables, images, slash commands, autofill fields) rather than trying to reproduce the original error.2026-08-04.16-51-36.mov
🤖 Generated with Claude Code