Skip to content

feat(trials): make result creation rule-window aware - #344

Merged
asku1990 merged 8 commits into
feature/bej-103-admin-trial-event-and-result-creationfrom
feat/bej-103-rule-window-aware-creation
Jul 23, 2026
Merged

feat(trials): make result creation rule-window aware#344
asku1990 merged 8 commits into
feature/bej-103-admin-trial-event-and-result-creationfrom
feat/bej-103-rule-window-aware-creation

Conversation

@asku1990

@asku1990 asku1990 commented Jul 23, 2026

Copy link
Copy Markdown
Owner

Summary

Implement BEJ-103 R3A for rule-window-aware manual result creation.

  • Propagate the event's persisted trialRuleWindowId through the admin result-create flow.
  • Resolve create-time score, era, and Lisätiedot configuration through a central rule-window registry.
  • Verify the trw_post_20230801 (1.8.2023+) field set, terminology, semantic input controls, and persistence mapping.
  • Keep older, null, and unknown rule windows on an explicit warned compatibility fallback that preserves the existing create behavior.
  • Keep existing result editing unchanged.
  • Document the rule-window architecture and create-flow behavior.

Scope

This PR implements R3A correctness only.

Included:

  • Rule-window-aware field selection for manual result creation.
  • Verified 2023+ score, era, and Lisätiedot configuration.
  • Registry-driven semantic input handling and serialization.
  • Compatibility fallback for historical and unknown rule windows.
  • Documentation and targeted tests.

Not included:

  • R3B create-form UX redesign.
  • Rule-window-aware result editing.
  • Backend write-contract changes.
  • Schema or migration changes.
  • Historical rule-window verification.

Validation

  • Registry tests for verified and fallback rule windows.
  • Create-model serialization tests.
  • Entry section, era section, and Lisätiedot rendering tests.
  • Contract, server, and database mapping tests.
  • Web type checking.
  • Lint (without cycle lint).

Changelog

Includes a user-visible changelog entry for rule-window-aware manual result creation and the compatibility fallback behavior.

@vercel

vercel Bot commented Jul 23, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated (UTC)
beagle-db-v2 Ignored Ignored Preview Jul 23, 2026 10:51am

asku1990 added 3 commits July 23, 2026 11:14
  Resolve the manual result-create field set from the trial event’s
  persisted
  rule window.

  - add trialRuleWindowId to admin event details
  - configure and verify the current 2023+ score, era, and lisätieto
    fields
  - hide obsolete tja and pin score fields for current rules
  - use Ajotaito for the current rule period
  - align lisätieto codes, parts, input types, and marker persistence
    with the PDF
  - retain a warned legacy fallback for older and unknown rule windows
  - preserve existing result-edit behavior

  ref bej-103
@asku1990 asku1990 changed the title docs/bej-103-creation-planning feat(trials): make result creation rule-window aware Jul 23, 2026
@asku1990
asku1990 marked this pull request as ready for review July 23, 2026 10:51
@asku1990
asku1990 merged commit 2b8abf2 into feature/bej-103-admin-trial-event-and-result-creation Jul 23, 2026
5 checks passed
@asku1990
asku1990 deleted the feat/bej-103-rule-window-aware-creation branch July 23, 2026 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant