refactor: centralize component ownership and generation disposal - #383
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A component could be disposed repeatedly during reentrant cleanup, retain a child scope after a strict cleanup failure, or attach a lifecycle callback's returned cleanup after its lifetime had ended. Navigation also copied and reset component fields itself.
This change gives each lifetime one runtime ownership record and one disposal path. Component and keyed/control scope cleanup, resource/watch/query attachments, and cancellation use that owner. Lifecycle settlement captures its invoking lifetime, renderer reuse rejects disposed owners, and root preparation/rollback/retirement moves into runtime capabilities. The compatibility adapter preserves published owner properties and callback/readable-map identity through backed views, including extension-created records.
Validation:
ffa0ff4pass all 19 touched rows: every capture meets the quality rules and every median change stays within 5%. The largest slowdown is 4.55% for table truncation. Full per-run statistics and provenance are indocs/benchmarks/core-ownership-8847810.json; no optimization claim.Stage 3 of the core consolidation series. Renderer range ownership and the shared commit coordinator remain the following stages.