Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #7.
A malformed removal receipt could authorize deletion of a sibling file or empty directory and then disappear with a successful result. Preflight all created entries, directory entries, hashes, and resolved receipt paths before any deletion. Invalid receipts exit 2 and preserve both the receipt and canaries, including an otherwise valid entry listed before the invalid one.
Reject absolute paths, empty or dot components, parent traversal, malformed entry types, and links resolving outside the explicit target. Intentional target-root links still work. Ordinary nested scaffold removal and user-edited file skipping retain their existing behavior.
Validation:
python3 -m unittest discover -s tests: 50 tests pass.python3 build/verify-all.py: all 15 steps pass on a byte-identical disposable snapshot, including fresh install against the proposed committed snapshot.git diff --check: clean.Privacy gates were run against exact copies of all proposed source files; the worktree administration file was excluded because it contains the local checkout path. No source or test files were excluded. This preflight addresses malformed receipts present when removal begins; it does not add protection against concurrent filesystem mutation.