Skip to content

Reapply "[OMEGA-239] implements safe history and prompt files"#257

Merged
vsbogd merged 4 commits into
mainfrom
OMEGA-239-safe-file-processing
Jul 16, 2026
Merged

Reapply "[OMEGA-239] implements safe history and prompt files"#257
vsbogd merged 4 commits into
mainfrom
OMEGA-239-safe-file-processing

Conversation

@paul-v-snet

Copy link
Copy Markdown
Collaborator

This reverts commit ba03406.

Description

  • Added safe behavior for cases where history files (memory/history.metta) or prompt files (both default and provider-specific) are missing for any reason.
  • Updates Autotests/helper.py functions dexec and dexec_root to explicitly output command errors to the console when they occur. This makes debugging local environment configuration issues easier by providing clearer error information during test execution.

How Has This Been Tested?

Via running mock autotests - all passed successfully including new ones

Checklist

  • The code generated by LLM is reviewed by the PR creator
  • Self-review completed
  • Test scenarios above are passed with the version of the code from PR

@paul-v-snet paul-v-snet requested a review from vsbogd July 16, 2026 07:29

@vsbogd vsbogd left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

TossSky added 3 commits July 16, 2026 19:12
The two tests added for safe history and prompt file reading are not listed in
Autotests/run_mandatory, so CI never runs them and a regression in the feature
would go unnoticed.

Both are plain mock tests using the llm/comm fixtures and the same -t test
container run_mandatory already brings up, so they need nothing extra.

run_mandatory goes from 49 to 52 passed.
[OMEGA-239] Register the new memory safety tests in run_mandatory
@TossSky

TossSky commented Jul 16, 2026

Copy link
Copy Markdown
Collaborator

Tested OMEGA-239.

What I checked:

  • Without the change all three cases fail: the agent stops responding when
    memory/history.metta is missing, and when prompt.txt or prompt_Test.txt is
    missing ("Agent did not respond (might have crashed on read/write)",
    "Agent crashed or failed to respond due to missing prompt")
  • With the change the same three pass: history.metta is recreated, a missing
    default prompt falls back to an empty string, a missing provider prompt falls
    back to the default
  • run_mandatory: 52 passed

The two new tests were not listed in Autotests/run_mandatory, so CI never collected
them and a regression here would have gone unnoticed. That is now registered and
merged into this branch, collection goes 49 -> 52.

Verdict: PASS

@vsbogd vsbogd merged commit 5493d49 into main Jul 16, 2026
2 checks passed
@vsbogd vsbogd deleted the OMEGA-239-safe-file-processing branch July 16, 2026 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants