[OMEGA-174] Multi-line command argument parsing of MeTTaClaw

[patham9]

Description

Multi-line argument was restricted to send command, and parsing seemed more complex than necessary.

How Has This Been Tested?

Tested with MeTTaClaw live Max Botnick instance.

Checklist

• The code generated by LLM is reviewed by the PR creator
• Self-review completed
• Test scenarios above are passed with the version of the code from PR

[patham9]

The autotest with ((command fails, this double parenthesis case occurs? If so it can be extended to handle it.

[vsbogd]

The autotest with ((command fails, this double parenthesis case occurs? If so it can be extended to handle it.

The reason test fails is additional quote inside the string:

E       assert '((send "\\"P...arf planet"))' == '((send "Plai...arf planet"))'
E         
E         - ((send "Plain text version:\n**Mars** - red planet\nNote: Pluto is a dwarf planet"))
E         + ((send "\"Plain text version:\"\n**Mars** - red planet\nNote: Pluto is a dwarf planet"))
E         ?        ++                    ++

My opinion the behavior of your code @patham9 is correct in this sense. I would suggest fixing the test assert condition:

-    assert balance_parentheses('send "Plain text version:"\n**Mars** - red planet\nNote: Pluto is a dwarf planet') == '((send "Plain text version:\\n**Mars** - red planet\\nNote: Pluto is a dwarf planet"))'
+    assert balance_parentheses('send "Plain text version:"\n**Mars** - red planet\nNote: Pluto is a dwarf planet') == '((send "\\\"Plain text version:\\\"\\n**Mars** - red planet\\nNote: Pluto is a dwarf planet"))'

[vsbogd]

I agree this change improves the previous implementation. I would also ask to add the unit tests which checks that multi-line parsing works for the commands other than send.

[vsbogd]

This function is not used and could be removed:

Suggested change

	def _strip_outer_parens(line):
	if line.startswith("(") and line.endswith(")"):
	return line[1:-1].strip()
	return line

[vsbogd]

Not sure why empty string is added into the current block? No tests are broken if it is removed:

Suggested change

	if cur:
	cur.append(raw)

[patham9]

If it executes commands like write-file, the additional newlines can matter. This just preserves this, as else it would truncate them.

[vsbogd]

This deserves to be a global constant like LLM_COMMANDS.

[patham9]

I agree. Maybe TWO_ARG_COMMANDS

[vsbogd]

@patham9 why this replacement is needed? No test is broken if removed.

[patham9]

Not needed anymore probably, was more an issue with Minimax M2.7 that it used listings without command.

[vsbogd]

Could we change the code of quote_arg to include this condition. I.e. make quote_args adding quotes only if they are absent. If so it would significantly simplify the code by removing this condition from balance_parenthesis function. For example this condition will turn to:

sexprs.append(f"({cmd} {filename} {quote_arg(content)})")

the same for if rest block below.

[patham9]

I am not sure about this, but it should be fine too.