Repository navigation
fix: improve native editing latency and fit expanded tables - #30
Merged
Merged
Conversation
Signed-off-by: Adam Jesionkiewicz <adam@jesion.pl>
Signed-off-by: Adam Jesionkiewicz <adam@jesion.pl>
Signed-off-by: Adam Jesionkiewicz <adam@jesion.pl>
Signed-off-by: Adam Jesionkiewicz <adam@jesion.pl>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Editing the 127 kB sample from #24 paid expensive AppKit-backed string statistics and whole source-pane updates during rich editing. Materialize document UTF-8 once, defer hidden source work, and patch changed UTF-16 text and highlighting while preserving editor identity, selection, Unicode and fence handling. Hidden source cannot publish stale input; line splits and Undo recolor the moved suffix.
Expanded tables clamp their preferred minimum to available width, excluding classic scrollbar space. Intrinsically wider content remains fully scrollable inside its rounded surface. The expansion action stays clear of headers and the preceding table, including the smallest custom text size. The width policy follows jedrzejsieracki's #27 proposal.
Validation:
Two independent subagents reviewed native editing and rendering without inherited implementation history. They found stale suffix colors, clipped intrinsic table content and small-text action overlap. All were fixed; both reviewers repeated their review and left no unresolved findings in scope. This independent agent review is separate from a GitHub approval submission.
Method, final raw data and limits: docs/EDITING_PERFORMANCE.md.
Fixes #27. Refs #24; keep it open for the reporter's retest after release.
Based on current main 9b0cae9. The signed/notarized 1.8 release artifacts remain intact; no new public release is made here. Windows #22 / PR #28 are outside scope.