Skip to content

Migrate Danger to use danger-pr-comment workflow, fix tests on Ruby 3.4+ and 4.0#117

Merged
dblock merged 1 commit into
ashkan18:masterfrom
dblock:update-danger-workflow
Jun 11, 2026
Merged

Migrate Danger to use danger-pr-comment workflow, fix tests on Ruby 3.4+ and 4.0#117
dblock merged 1 commit into
ashkan18:masterfrom
dblock:update-danger-workflow

Conversation

@dblock

@dblock dblock commented Jun 10, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • Migrated Danger to use the reusable numbata/danger-pr-comment workflow
  • Removed Gemfile.danger, moved danger gems into a :danger group in the main Gemfile
  • Added danger-comment.yml workflow to post Danger results as PR comments
  • Added Ruby 4.0 to CI matrix
  • Fixed tests on Ruby 3.4+ and 4.0:
    • Added mutex_m and ostruct gems (no longer bundled by default)
    • Fixed Sinatra 4 host authorization blocking test requests (set :environment, :test)
    • Fixed halt!halt in dummy Sinatra app
    • Updated error message assertion to work across Faraday versions

@dblock dblock requested review from ashkan18 and yuki24 June 10, 2026 21:59
@dblock dblock force-pushed the update-danger-workflow branch 6 times, most recently from e3ac95b to 07ae912 Compare June 10, 2026 22:14
…flow

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@dblock dblock force-pushed the update-danger-workflow branch from 07ae912 to 5f1e828 Compare June 10, 2026 22:16
@dblock dblock changed the title Update Danger workflow to use numbata/danger-pr-comment reusable workflow Migrate Danger to use danger-pr-comment workflow, fix tests on Ruby 3.4+ and 4.0 Jun 10, 2026
@dblock dblock enabled auto-merge June 10, 2026 22:17
@dblock dblock merged commit fd0ef88 into ashkan18:master Jun 11, 2026
12 checks passed
@dblock dblock deleted the update-danger-workflow branch June 11, 2026 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants