[Feature]: Add on crash uploaded SourceMod forward - #42
Merged
Conversation
commit c7efce2 Author: caxanga334 <10157643+caxanga334@users.noreply.github.com> Date: Sat Nov 22 22:35:24 2025 -0300 Fix Error commit e8acf9f Author: caxanga334 <10157643+caxanga334@users.noreply.github.com> Date: Sat Nov 22 22:23:57 2025 -0300 Fix Possible Memory Leak commit 51e7189 Author: caxanga334 <10157643+caxanga334@users.noreply.github.com> Date: Sat Nov 22 22:13:55 2025 -0300 Add Upload Forward
sapphonie
previously requested changes
Nov 23, 2025
sapphonie
left a comment
sapphonie
left a comment
Collaborator
There was a problem hiding this comment.
Looks fine enough, please respond to the review comments. I think I'd also like to see an example plugin using the .inc somewhere, other than that this looks great. Thanks for the PR!
Forward notifies plugins when the extension is done uploading. Plugins can fetch data from uploaded crashes via natives. Added example plugin.
Kenzzer
self-requested a review
November 24, 2025 14:29
Kenzzer
requested changes
Nov 24, 2025
Kenzzer
left a comment
Kenzzer
left a comment
Collaborator
There was a problem hiding this comment.
Amazing work! Just a few nitpicks
Kenzzer
approved these changes
Nov 24, 2025
Removed timer example. Added example of how to handle plugin late loads.
Collaborator
|
Okay yay |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds a SourceMod forward for when a crash is uploaded.
Closes #26