Horiz spatial domain bugfix & implement more geometry related factories - #52
Merged
Conversation
benbart
force-pushed
the
bbarton/PR-7400
branch
2 times, most recently
from
April 22, 2026 23:34
f871a6f to
59f8b88
Compare
benbart
requested review from
Cameronsplaze,
gjclark,
mattp0,
mckadesorensen and
reweeden
April 22, 2026 23:37
reweeden
reviewed
Apr 23, 2026
reweeden
left a comment
Contributor
There was a problem hiding this comment.
If needed for development you can always point the pinned version of mandible in your requirements.in file to a branch or commit hash instead of a release tag. That way you can make sure you've got all the changes you need for your work before making a new mandible release which should reduce the need for making multiple releases and updating the dependencies in CIRRUS multiple times.
Overall looks good, just some small consistency things.
benbart
force-pushed
the
bbarton/PR-7400
branch
from
April 23, 2026 16:53
b317583 to
21702dd
Compare
benbart
force-pushed
the
bbarton/PR-7400
branch
from
April 23, 2026 18:37
21702dd to
1a95b4d
Compare
reweeden
approved these changes
Apr 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
I have: