refactor: cleanup and simplification of time interface#203
Merged
Conversation
Some things I noticed while working on the documentation that made me scratch my head once trying to think how to explain to users; decided to simplify a bit. - Rename asdf_time_base_format_t to just asdf_time_format_t - The is_base_format flag is not used anywhere for anything right now so get rid of it; not exactly sure what Joe's plan was for extended formats but it's not used yet. Checking is_base_format is also a question of just checking asdf_format_t > ASDF_FORMAT_RESERVED1 - Shouldn't have functions declared ASDF_LOCAL in public headers; only ASDF_EXPORT -- left a simpler asdf_time_parse function that can take a partially initialized asdf_time_t and fill in the time info. - Misc other code cleanup.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some things I noticed while working on the documentation that made me scratch my head once trying to think how to explain to users; decided to simplify a bit.