fix(release): support Linux ARM64 builds - #475
Merged
Merged
Conversation
Cast libyaml's problem pointer to the target-native c_char type and exercise the shipped binaries on an ARM64 runner. Signed-off-by: Tom Ballard <tom@armytage.co>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
c_chartype before passing it toCStr::from_ptrubuntu-24.04-armrelease build gate for the shipped CLI and MCP binariesWhy
The v0.29.0 release run exposed a Linux ARM64-only compile error because
c_charis unsigned on that target whileunsafe-libyamlexposes the field as*const i8. The cast preserves the existing bytes and letsCStruse the platform-native pointer type.Failed release job: https://github.com/asdecided/core/actions/runs/33317160802/job/99273737990
Verification
cargo +1.94.1 clippy -p asdecided-core --lib -- -D warningscargo +1.94.1 test -p asdecided-core --lib— 126 passedcargo +1.94.1 build --release --locked -p decided -p decided-mcpThe added ARM64 job will validate the exact PR head on a native runner.