fix(agent): reset session state between reviews - #855
Open
HissanT wants to merge 12 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes the stale agent session-state bug where a later review for the same profile could keep tool results from an earlier review. The orchestrator now starts each review run with a fresh in-memory context cache and saves only the current review's tool results to the session store.
Issue
Closes #43
Changes
tests/unit/test_orchestrator_session_state.py.ContextManagerat the start of each review run.docs/JOURNAL.mdwith Week 9 check-ins and validation notes.Testing
make test-unit) with documented pre-existing failures/no new failuresmake test-integration)make lint) on touched files; full repo has documented pre-existing failuresmake typecheck) with documented pre-existing failures/no new touched-file failuresFocused validation:
.venv\Scripts\pytest.exe tests\unit\test_orchestrator_session_state.py -v -m unit-> 2 passed.venv\Scripts\ruff.exe check agent\orchestrator.py tests\unit\test_orchestrator_session_state.py-> passed.venv\Scripts\black.exe --check agent\orchestrator.py tests\unit\test_orchestrator_session_state.py-> passedFull-suite note:
makeis not available in my local PowerShell environment, so I ran the matching virtualenv commands directly.Screenshots / Demo
Not applicable.
Notes for Reviewers
Please focus on
agent/orchestrator.pyandtests/unit/test_orchestrator_session_state.py. The intended behavior is that each new review gets fresh tool state, while memoization remains available inside the current run only.