Repository navigation
Fix macOS VLC integration on Apple Silicon/Intel; add Homebrew cask - #7
Merged
Merged
Conversation
VLC for macOS only loads lib*_plugin.dylib, but the plugin was built with CMake's default .so module suffix, so every macOS release was silently ignored by VLC. Build it as .dylib. - Pin CMAKE_OSX_DEPLOYMENT_TARGET to 14.0 (the osx-arm64 ONNX Runtime minimum) so packages built on the newest runners load on older Macs. - Use ONNX Runtime 1.23.2 for Intel/universal2 macOS; 1.26.0 has no x86_64 macOS archive, so the Intel package shipped without a runtime. Never pick up a Homebrew onnxruntime for macOS packages. - Ad-hoc sign packaged dylibs that do not verify (optional Developer ID). - Ship install_icop_plugin.sh inside Linux/macOS archives; add --release-dir and --arch. On macOS, find VLC.app from the DMG, Homebrew cask (incl. --appdir), ~/Applications, MacPorts or Spotlight; match the payload to VLC's architecture (Rosetta aware); reject VLC 4; clear download quarantine; remove the stale .so; tolerate a missing vlc-cache-gen. - Add verify_macos_package.sh and macos_vlc_smoke_test.sh, run them in release CI with Homebrew VLC, and check plugin registration in PR CI. - Document macOS installation paths and troubleshooting. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01VDfqb9f52nSf89az5rPZBz
- install_icop_plugin.sh --uninstall removes exactly the files listed in the release SHA256SUMS; the Homebrew cask uses it on uninstall. - New homebrew-tap workflow dispatches icop-release to asayed18/homebrew-icop when a release is published (optional HOMEBREW_TAP_TOKEN; the tap also polls on a schedule). - Document `brew install --cask icop`. - Bump to 0.1.7 so the fixed macOS packages do not reuse the v0.1.6 draft. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01VDfqb9f52nSf89az5rPZBz
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
lib*_plugin.dylib, but the plugin was built with CMake's default.sosuffix. It is now built as.dylib.CMAKE_OSX_DEPLOYMENT_TARGETto 14.0. Use ONNX Runtime 1.23.2 for Intel/universal2 (1.26.0 has no x86_64 macOS archive). Ad-hoc sign packaged dylibs.install_icop_plugin.sh): ships inside the archives and adds--release-dir,--archand--uninstall. It finds VLC.app (DMG, Homebrew cask,~/Applications, MacPorts, Spotlight) and matches the payload to VLC's architecture (Rosetta aware). It also rejects VLC 4, clears quarantine and tolerates a missingvlc-cache-gen.verify_macos_package.shandmacos_vlc_smoke_test.shto release CI, and a plugin-registration check to PR CI.homebrew-tapworkflow notifiesasayed18/homebrew-icopon release (brew install --cask icop).Local verification (macOS arm64, VLC 3.0.23)
make release: v0.1.7 mac package built (7 payload files).verify_macos_package.sh releases/v0.1.7/mac arm64: passed.macos_vlc_smoke_test.sh /Applications/VLC.app sample.mp4 releases/v0.1.7/mac/plugins: VLC registeredicop, and the ONNX session was ready with the coreml,cpu provider.make test) were not run locally.🤖 Generated with Claude Code