Skip to content

perf(semantic-search): snapshot manifest partitions #65

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aryasaatvik merged 2 commits into from
Jun 26, 2026
Merged

perf(semantic-search): snapshot manifest partitions #65

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
88807d0
perf(semantic-search): pin manifest snapshots per run
aryasaatvik Jun 24, 2026
65d62e1
test(semantic-search): assert snapshot test fixture (greptile)
aryasaatvik Jun 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
39 changes: 39 additions & 0 deletions packages/plugins/semantic-search/src/sdk/tool-search-index.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1032,6 +1032,45 @@ describe("ToolSearchIndex manifest snapshot", () => {
}),
);

it.effect("scans the create-time manifest snapshot when the live manifest changes", () =>
Effect.gen(function* () {
const [tool] = makeTools(1);
expect(tool).toBeDefined();
if (tool === undefined) return;
Comment thread
aryasaatvik marked this conversation as resolved.
let liveManifests = [manifestForTool(tool, "fp-at-create", "source-at-create")];
const counters = { manifest: 0 };
const executor: Pick<Executor, "tools" | "cache"> = {
tools: {
list: () => Effect.succeed([tool]),
manifest: () => {
counters.manifest++;
return Effect.succeed(liveManifests);
},
schema: () => Effect.succeed(null),
},
cache: makeMemoryCache(),
};
const base = makeBase(executor as Executor);

yield* create({ ...base, runId: "run-snapshot-stability", partitionCount: 1 });
liveManifests = [manifestForTool(tool, "fp-after-create", "source-after-create")];

const scanned = yield* scan({
...base,
runId: "run-snapshot-stability",
partition: 0,
limit: 10,
});

expect(scanned).toMatchObject({ processed: 1, changed: 1, skipped: 0 });
expect(counters.manifest).toBe(1);
expect([...base.jobs.data.values()][0]).toMatchObject({
fingerprint: "fp-at-create",
sourceRevision: "source-at-create",
});
}),
);

it.effect("fails the scan when the run snapshot is missing (no D1 fallback)", () =>
Effect.gen(function* () {
const { executor, counters } = makeCountingExecutor(makeTools(2));
Expand Down
Loading