Feat/built in feature flag - #17
Conversation
|
Warning Review limit reached
Next review available in: 23 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (6)
📝 WalkthroughWalkthroughAdds typed feature-flag utilities with client/server access rules, requires ChangesFeature flag configuration
Estimated code review effort: 3 (Moderate) | ~20 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 5
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@hooks/useFeatureflags.ts`:
- Around line 16-18: Update the demoMode value in useFeatureflags to normalize
clientConfig.NEXT_PUBLIC_DEMO_MODE to a boolean by reusing the shared enablement
helper or checking equality with "true"; ensure the hook’s result type exposes
demoMode as boolean so the string "false" cannot enable demo behavior.
- Line 3: Update the client-facing hooks/useFeatureflags.ts import so it no
longer references the server-inclusive `@/lib/config` module. Split or use the
existing client-safe configuration module, ensuring clientConfig remains
available without importing serverConfig or invoking getServerConfig() in the
"use client" module graph.
In `@lib/config/index.ts`:
- Line 35: Update the NEXT_PUBLIC_DEMO_MODE schema and configuration boundary to
accept only "true" or "false" and normalize the value to a boolean. Ensure
useFeatureFlags() exposes the same boolean result used by
isEnable("NEXT_PUBLIC_DEMO_MODE"), preserving consistent component conditionals.
In `@lib/feature-flags.ts`:
- Around line 38-56: Update isEnable so the client/server restriction is
evaluated before the overrides branch: on the client, only flags starting with
"NEXT_PUBLIC_" may use overrides, while server-only flags must return false.
Preserve override priority for server-side calls and the existing client-safe
configuration behavior.
- Around line 13-18: Align the FEATURE_FLAGS entry
NEXT_PUBLIC_FEATURE_NEW_DASHBOARD with the clientConfig validation by adding the
corresponding field to clientSchema, including the appropriate type and
optionality used for client feature flags. Alternatively, remove the flag from
FEATURE_FLAGS until schema support is wired, ensuring isEnable() cannot
reference an unvalidated configuration key.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: e8f014f4-590e-48aa-8eb0-7751249c8c0b
📒 Files selected for processing (4)
hooks/useFeatureflags.tslib/config/index.tslib/email/index.tslib/feature-flags.ts
Summary by CodeRabbit