Skip to content

Fixed issue #7: JSON parsers uses always default configuration #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
marwoj wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fixed issue #7: JSON parsers uses always default configuration #16

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions dist/angularjs-google-places.min.js
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

10 changes: 5 additions & 5 deletions src/angularjs-google-places.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,9 +25,9 @@ provider('ngGPlacesAPI', function () {
_placeDetailsApiFnCall: 'getDetails'
};

var parseNSJSON = function (response) {
var parseNSJSON = function (response, req) {
var pResp = [];
var keys = defaults.nearbySearchKeys;
var keys = req.nearbySearchKeys;
response.map(function (result) {
var obj = {};
angular.forEach(keys, function (k) {
Expand All @@ -38,9 +38,9 @@ provider('ngGPlacesAPI', function () {
return pResp;
};

var parsePDJSON = function (response) {
var parsePDJSON = function (response, req) {
var pResp = {};
var keys = defaults.placeDetailsKeys;
var keys = req.placeDetailsKeys;
angular.forEach(keys, function (k) {
pResp[k] = response[k];
});
Expand All @@ -57,7 +57,7 @@ provider('ngGPlacesAPI', function () {

function callback(results, status) {
if (status == gPlaces.PlacesServiceStatus.OK) {
return deferred.resolve(req._parser(results));
return deferred.resolve(req._parser(results, req));
} else {
deferred.reject(req._errorMsg);
}
Expand Down