Repository navigation
ci: validate scheduled Map sync - #2
Closed
arunimshukla wants to merge 8 commits into
Closed
arunimshukla wants to merge 8 commits into
arunimshukla wants to merge 8 commits into
Conversation
Closes ethsystems#11. `SupportedBy.astro` was standalone and used only on `index.astro:370`. It's drop-in reusable, so About now imports and renders the same component — no copy or markup changes to the component itself. **Decisions taken on the three open questions** (none were settled at the offsite, per the thread on ethsystems#11): 1. **Placement** — between the Workshops block and "Talk to us", per review feedback. It reads as the last credibility signal before the contact CTA. (First pass put it directly under the header lede, per the issue's "above the fold" framing; that framing was the issue author's, not from the offsite recording.) 2. **Mark set** — the same four (BitMine, SharpLink, Joe Lubin, SNZ). An About-specific set isn't possible today; client/institution logos were explicitly ruled out for now. 3. **Copy** — identical to the homepage. ## Why the page body is now two sections The component is a full-bleed `<section>` with its own `.container` and a `border-bottom`. Dropping it inside `.about-inner` — itself a `.container` — would have nested containers, insetting the marks row relative to its neighbours and clipping the hairline to container width instead of running it edge to edge like on the homepage. So `.about-section` is split into `--body` (pipeline, team, workshops) and `--contact` (Talk to us), with `<SupportedBy />` a top-level sibling between them. The two halves drop the padding facing the component; its own `4rem` block padding supplies the gap on both sides. ## Verification - `npm run build` — clean. - `npm test` — 55 passed. (`build-graph.test.mjs > builds without errors` trips the global 5s `testTimeout` when a dev server and build run concurrently; alone with `--testTimeout=120000` it passes in 2.1s, 31/31. Unrelated to this change.) - Rendered against `npm run dev` at 1440px; DOM order confirmed as `.about-section--body` → `.supported` → `.about-section--contact` ("Talk to us"). Full-page before/after screenshots in the Slack thread. - Responsive rules come with the component: 2x2 at ≤900px, single column at ≤560px. Prompted by: ac --------- Co-authored-by: centaur <321619048+ethsystems-bot@users.noreply.github.com>
…ystems#48 Cherry-picks ethsystems#46 (sibling RFP links), ethsystems#47 (continuation-line glossary definitions), and ethsystems#48 (Custom UTXO link to Shielding), preserving @arunimshukla as commit author. Clean picks onto main; tests pass (62/62). Prompted by: ac --------- Co-authored-by: Arunim Shukla <54760103+arunimshukla@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Temporary validation PR for the exact rebased Map-sync candidate. This PR is not intended for upstream review or merge.