Repository navigation
fix: preserve continuation-line glossary definitions - #1
Open
arunimshukla wants to merge 1 commit into
Open
arunimshukla wants to merge 1 commit into
arunimshukla wants to merge 1 commit into
Conversation
arunimshukla
marked this pull request as ready for review
September 28, 2026 17:53
arunimshukla
force-pushed
the
fix/multiline-glossary-definitions
branch
from
September 28, 2026 18:10
7f83f5c to
0cce2a5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
parseGlossary()only reads definition text from the glossary term line. In the current map content,Data Availability Layer (DA Layer)places its definition on the immediately following line, so the generated entry contains an empty definition and is omitted from the public glossary.This change:
src/data/glossary.jsonwith the missing DA Layer definitionThe earlier glossary-link work from upstream ethsystems#45 is now present on
mainthrough commit63f99bd. This branch is rebased onto that commit and contains only this follow-up.Reproduction
Against current upstream
main:Data Availability Layer (DA Layer)is generated with"definition": ""After this patch, the term count remains 74 and the source definition is preserved.
Regression coverage
The tests cover:
Validation
npm test: 61/61 passednpm run lint:refs: passednpm run build: passed, 218 pages built