v2.2.0 — Mensa/café hours split, K/C room-tint fixes, seat-info toggle, copy shop - #13
Merged
Merged
Conversation
STWNO publishes the ground-floor café and the 1st-floor Mensa lunch service on separate pages with different hours (07:30-17:00 vs. 11:00-14:15); building F now shows both instead of conflating them. Building K also hosts real classrooms alongside its ground-floor café, so its map tint and free-room count no longer get clobbered by the café's open/closed state — only F and GH (pure amenity, no teaching rooms) still tint by hours. K's card also drops its STWNO link, since only the Mensa publishes an actual daily menu.
Matches the segmented-pill style already used for map amenities, and moves it between Room Type and Building so the filter panel reads as one consistent list instead of a lone checkbox at the bottom.
Room C 012 hosts a walk-in copy/print/binding service (Mon-Thu 09:00-14:00, closed Fri/weekends; THD's page gives no break-time hours, so the break is modeled as closed rather than guessed). Building C is mixed-use like K, so its map tint and free-room count keep tracking real classroom availability -- only its side-panel card reflects the copy shop's hours. Adds a third map glyph (printer) alongside the existing coffee cup and open book, drawn in the same halo-badge style.
THabella names these rooms descriptively ("Smart Lab (Veilchengasse)",
"Vorlesungssaal Veilchengasse 2") instead of the usual
"<Letter><Number> - name" convention, so parseBuilding's generic
leading-letters parse resolved them to "Smart"/"Vorlesungssaal" --
neither of which matched the V2 map key, leaving the footprint always
empty even though both rooms are live and teaching-eligible.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
<Letter><Number> - nameconvention, so the building parser resolved them to bogus codes and they silently fell off the map.package.json/package-lock.jsonto 2.2.0.Test plan
npm run typechecknpm test(80 tests passing, incl. newgetMensaCanteenHours/getCopyShopHours/ Veilchengasse mapper coverage)npm run build