Skip to content

fix: remove Node 22.22.0 pin, float back to 22 - #87

Merged
iskounen merged 1 commit into
mainfrom
iskounen/fix/unpin-node-version
Jun 25, 2026
Merged

fix: remove Node 22.22.0 pin, float back to 22#87
iskounen merged 1 commit into
mainfrom
iskounen/fix/unpin-node-version

Conversation

@iskounen

Copy link
Copy Markdown
Contributor

Summary

Removes the 22.22.0 pin added in PRs #85 and #86. Node 22.23.1 includes the upstream fix (nodejs/node#64004) that resolves the ERR_STREAM_PREMATURE_CLOSE regression introduced in 22.23.0. The Node version cache will be manually cleared to ensure runners pick up 22.23.1.

🤖 Generated with Claude Code

Node 22.23.1 includes the fix (nodejs/node#64004) for the http.Agent
change that caused ERR_STREAM_PREMATURE_CLOSE with node-fetch@2.
Cache will be manually cleared to pick up 22.23.1.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@claude

claude Bot commented Jun 25, 2026

Copy link
Copy Markdown
Contributor

Code Review

Summary

This PR removes the exact 22.22.0 Node.js version pin across four GitHub workflow/action files, floating the default back to the major version 22. This is a small, focused infrastructure change that follows up on the recent pin (commit 78f1fc5).

Issues Found

None. The change is correct and consistent.

I verified the following:

  • All four changed files (setup-and-install/action.yml, add-version-label.yml, danger-yarn.yml, danger.yml) previously defaulted to "22.22.0" and now default to "22".
  • This now matches the existing defaults in tests.yml:7 and npm-audit.yml:7, which were already "22". So the repo's node-version defaults are now uniform.
  • grep for 22.22.0 / 22.22 across .github and package.json returns no remaining references — nothing was left inconsistent, and no caller passes the old pinned value explicitly.
  • The only other Node versions referenced are claude-review.yml ("22") and link-pr-to-notion.yml ('20'), both unrelated to these inputs.

Areas Reviewed

  • Architecture & Design: Floating to 22 trades exact reproducibility for automatic patch/minor updates. Given the rest of the repo already used the floating "22" default, this is the more consistent choice. Worth a one-line note: the setup-node action with node-version: '22' resolves to the latest available 22.x at run time, so CI could pick up a new minor/patch without a code change — that's the intended behavior here per the commit message ("float back to 22").
  • Security / Performance / Bugs: Not applicable — no runtime or application code changed.
  • Testing: No tests needed for this config change.

Looks good to merge. ✅

@iskounen
iskounen merged commit d4d4268 into main Jun 25, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant