Skip to content

chore: upgrade danger to 13.0.10 - #76

Merged
iskounen merged 1 commit into
mainfrom
iskounen/fix/upgrade-danger-to-13.0.10
Jun 25, 2026
Merged

chore: upgrade danger to 13.0.10#76
iskounen merged 1 commit into
mainfrom
iskounen/fix/upgrade-danger-to-13.0.10

Conversation

@iskounen

Copy link
Copy Markdown
Contributor

Summary

  • Upgrades danger from 13.0.4 to 13.0.10
  • Removes node-fetch from the dependency tree (replaced with undici in danger-js PR #1514)

Why

The run-danger-yarn job has been intermittently failing across Artsy repos with:

ERR_STREAM_PREMATURE_CLOSE: Invalid response body while trying to fetch https://api.github.com/repos/.../pulls/.../files

This is a known fragility in node-fetch v2 when GitHub's API drops a keep-alive connection mid-stream. danger 13.0.10 (released today) replaces node-fetch with undici, which handles this correctly.

Test plan

  • Merge and verify run-danger-yarn passes consistently on a PR in eigen or another affected repo

🤖 Generated with Claude Code

Fixes intermittent ERR_STREAM_PREMATURE_CLOSE failures in the
run-danger-yarn CI job. danger 13.0.10 replaces node-fetch with
undici (danger-js#1514), which handles GitHub API connection drops
more reliably.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@claude

claude Bot commented Jun 25, 2026

Copy link
Copy Markdown
Contributor

Code Review

Summary

This PR bumps the pinned danger dependency from 13.0.4 to 13.0.10 in package.json, with the corresponding yarn.lock updates. There are no source code changes.

Issues Found

None. This is a routine patch-level dependency upgrade.

I verified the yarn.lock diff is internally consistent with the danger@13.0.10 dependency tree:

  • Dropped transitive deps (no longer required by danger 13.0.10): http-proxy-agent, https-proxy-agent, agent-base, @tootallnate/once, get-stdin, lodash.find, lodash.keys, plus the now-unreferenced chalk@^2.x / ansi-styles@^3.x / color-convert@^1.x / escape-string-regexp@^1.x / has-flag@^2.0.0 / supports-color@^5.x chain.
  • Added/upgraded to match danger 13.0.10's manifest: chalk@^4.1.2, supports-hyperlinks@^4.3.0 (→ supports-color@^10.2.2, has-flag@^5.0.1), and undici@6.21.1.
  • node-fetch and p-limit selectors were narrowed (^2.6.7 / ^2.1.0 ranges removed) since danger no longer requests them — the resolved versions are unchanged.

Areas Reviewed

  • Architecture & Design: No code changes. Danger is invoked via node_modules/.bin/danger in .github/workflows/danger.yml; the upgrade requires no workflow changes.
  • Compatibility: The workflows run on Node 22 (.github/workflows/danger.yml), which satisfies the upgraded transitive deps (e.g. supports-color@10 requires Node 18+). No engines conflicts.
  • Security: Removing the proxy-agent chain and bumping to undici@6.21.1 is a net positive. No new direct dependencies were introduced beyond what danger pulls in.
  • Bugs & Edge Cases: None identified — danger remains pinned to an exact version, consistent with the prior entry.

LGTM. 👍

@leamotta leamotta left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!

@iskounen
iskounen merged commit 79cc799 into main Jun 25, 2026
6 of 7 checks passed
@iskounen
iskounen deleted the iskounen/fix/upgrade-danger-to-13.0.10 branch June 25, 2026 21:06
iskounen added a commit that referenced this pull request Jun 25, 2026
revert: undo danger upgrades, back to pre-#76 state
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants