Repository navigation
feat: native DSH ACP backend with compact tools and reliable session events - #2939
Closed
kui123456789 wants to merge 1 commit into
Closed
kui123456789 wants to merge 1 commit into
kui123456789 wants to merge 1 commit into
Conversation
This was referenced Sep 11, 2026
Closed
Owner
|
Limited maintenance audit — October 1, 2026. Scope: a new DSH provider and ACP transport are explicitly outside limited maintenance. This is a scope decision, not a judgment against the contribution; the branch remains available for reuse. Closing this PR does not close or mark the underlying bug as fixed. Conflicts and age were not used as quality criteria. Automatic issue reporting remains disabled. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes
Add DeepSeek Harness (DSH) as an opt-in native ACP backend to the existing ComfyUI MCP orchestrator. A user with an already-configured DSH CLI can select its models from the companion Agent Panel, keep DSH session history and memory, and operate ComfyUI through the existing MCP servers.
Proposal: #2938. Companion panel: artokun/comfyui-mcp-panel#2304.
I have read the sunset notice. This contribution is offered for review/merge or reuse by a successor; it does not assume the project will resume releases. Prepared with AI assistance (OpenAI Codex).
ACP runtime and configuration
dsh-discovery.ts,dsh-transport.ts,dsh-profile.ts, anddsh-backend.ts, using@agentclientprotocol/sdk@1.4.0rather than a private DSH Web protocol.--profile acp; use a temporary startup/settings overlay for the exact provider/model. DSH reads its own credentials. Consume child diagnostics without forwarding raw provider bodies to the browser.Correctness fixes included with the adapter
Image processing uses the repository's
requireSharpentry point. Error messages are categorized/redacted and do not expose upstream credentials or endpoints. No private DSH history deletion or cross-Web execution API is introduced.Prompt and tool budget
full. All business tools remain available throughlist_tools,describe_tool, andcall_tool.panel.persona.dsh, separate from the shared persona. Load detailed model/operation skills on demand, require live panel tools for canvas actions, and do not turn an image-read failure into a new generation.Validation
npm run buildandnpm run lint: passed.npm test: 14,321 tests passed, 5 failed (783 test files). All 12 non-changelog static/documentation gates passed. The overall command exits 1; this is not a green full-suite claim.1d5b12b1:late-mutation-e2e,panel-template-relay-production,skills-access-panel-template-relay.integration, anddivergent-install-reachable. The fifth, themodel-managementpending-visibility case, passed when rerun individually on both this branch and clean upstream; its full-suite failure remains disclosed as an unresolved intermittent result.check:changelogalso fails unchanged on clean upstream: release 0.52.203 omits shipped PR chore: remove docker/ and the anti-slop lint tooling #2928. No unrelated release-history rewrite is included.main; it is not a copy of the deployment's complete patched dist tree.Compatibility and review boundaries
The panel companion is needed for the DSH picker, raw token readout,
think_endandprocesspresentation. Upstream shared-conversation behavior is retained: a fresh browser tab is not an isolated production test. Use a separate orchestrator or injected ACP fixtures.The ownership guard is process-local; do not execute the same session concurrently in DSH Web. Audio input, private Web thinking snapshots, backend history deletion, launcher/service rewrites, background-session architecture changes, model downloads and node-management changes are outside this PR. The raw turn-size guard does not bound the provider's entire historical context.
No credentials, private sessions, workstation/server addresses, model weights, generated media or deployment backups are included. The release version remains upstream-controlled. See
NATIVE-DSH.mdfor setup, capabilities, measurement context and limitations.