Skip to content

chore(deps-dev): bump @types/node from 22.19.11 to 26.4.1 - #2676

Closed
dependabot[bot] wants to merge 1 commit into
mainfrom
dependabot/npm_and_yarn/types/node-26.4.0
Closed

dependabot[bot] wants to merge 1 commit into
mainfrom
dependabot/npm_and_yarn/types/node-26.4.0

Conversation

@dependabot

@dependabot dependabot Bot commented on behalf of github Aug 31, 2026 •

Copy link
Copy Markdown
Contributor

Bumps @types/node from 22.19.11 to 26.4.1.

Commits

@dependabot @github

dependabot Bot commented on behalf of github Aug 31, 2026

Copy link
Copy Markdown
Contributor Author

Labels

The following labels could not be found: dependencies. Please create it before Dependabot can add it to a pull request.

Please fix the above issues or remove invalid values from dependabot.yml.

@artokun

artokun commented Sep 3, 2026

Copy link
Copy Markdown
Owner

Red here is not a dependabot problem — three of our own source lines only compile under the older types:

src/comfyui/client.ts          Type 'Buffer<ArrayBufferLike>' is not assignable to type 'BlobPart'
src/comfyui/cloud-client.ts    (same)
src/services/panel-launcher.ts Type 'string | NonSharedBuffer' is not assignable to 'Uint8Array<ArrayBufferLike>'

#2770 fixes those three on main, verified to typecheck under both 22.19.11 and 26.4.0 — so it is version-independent and can land first. Once it does, rebasing this branch should turn it green and leave it a pure dependency review.

Worth flagging one trap it documents: new Uint8Array(data.buffer) also silences the compiler and is wrong — Buffer.from views an 8KB pool, so that form would upload 8192 bytes instead of 7. Measured, and pinned with a test.

@artokun

artokun commented Sep 4, 2026

Copy link
Copy Markdown
Owner

This is red on all four legs for a reason that is already fixed elsewhere, and the merge order is the whole story.

@types/node 26 narrows BlobPart, so new Blob([buffer]) stops compiling:

src/comfyui/client.ts(1605,26): error TS2322: Type 'Buffer<ArrayBufferLike>' is not assignable to type 'BlobPart'.
src/comfyui/cloud-client.ts(414,26): error TS2322: …

#2770 fixes exactly those sites — both of them, plus src/services/panel-launcher.ts — behind one uploadBody() helper, and it is green on all four legs. So #2770 merges first, then this rebases clean; on its own this cannot go green no matter how many times it is rerun.

Worth flagging because the obvious rewrite is wrong in a way CI would not have caught: new Uint8Array(data.buffer) drops the offset and length, and Buffer.from returns a pooled buffer once the 8KB pool is in use — so that version uploads the whole pool with the caller's bytes somewhere inside it. #2770 pins that with a payload deliberately placed at a non-zero byteOffset.

Not touching this PR: dependency bumps are yours to merge.

@artokun

artokun commented Sep 4, 2026

Copy link
Copy Markdown
Owner

Verified that #2770 actually unblocks this, rather than taking the claim from its title. Merge order: #2770 first, then this.

What CI is failing on here — three type errors, nothing to do with the dependency resolving:

src/comfyui/client.ts(1605,26)          TS2322  Buffer<ArrayBufferLike> not assignable to BlobPart
src/comfyui/cloud-client.ts(414,26)     TS2322  Buffer<ArrayBufferLike> not assignable to BlobPart
src/services/panel-launcher.ts(1119,39) TS2322  string | NonSharedBuffer not assignable to Uint8Array

The test. I merged chore/types-node-26-compat into this branch and ran a real npm ci, so @types/node was genuinely 26.4.0 rather than the 22.19.11 sitting in my main checkout:

now installed: 26.4.0
tsc --noEmit  ->  0 errors

And the control, because agreement alone proves nothing. Same installed 26.4.0, with only #2770's three source files reverted:

src/comfyui/client.ts(1605,26)       TS2322  Buffer<ArrayBufferLike> not assignable to BlobPart
src/comfyui/cloud-client.ts(414,26)  TS2322  Buffer<ArrayBufferLike> not assignable to BlobPart

The exact two errors return at the exact lines CI reports. (That control also throws some unrelated noise, because reverting three files to an older revision breaks imports newer files depend on — those are artifacts of the mix, not findings.)

So the fix is confirmed to be what clears the errors, not the install. #2770's changes correspond one-to-one with them: new Blob([data]) → new Blob([uploadBody(data)]) at both Blob sites, and socket.on("data", (chunk: Buffer) => for the launcher, where 26 widens the callback to string | Buffer and Buffer.concat will not take the union.

Worth stating explicitly, because I nearly published the opposite: my first attempt typechecked this branch in a worktree that resolves node_modules from the main checkout — @types/node 22 — and reported 0 errors. That number was meaningless. Any "it typechecks" claim about a dependency bump is worthless unless the bumped package is the one actually installed.

Not merging either — dependency changes are yours. This is just the sequencing evidence.

Bumps [@types/node](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/node) from 22.19.11 to 26.4.1.
- [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases)
- [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/node)

---
updated-dependencies:
- dependency-name: "@types/node"
  dependency-version: 26.4.0
  dependency-type: direct:development
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot Bot changed the title chore(deps-dev): bump @types/node from 22.19.11 to 26.4.0 chore(deps-dev): bump @types/node from 22.19.11 to 26.4.1 Sep 10, 2026
@dependabot
dependabot Bot force-pushed the dependabot/npm_and_yarn/types/node-26.4.0 branch from 04ddc66 to 9d05c16 Compare September 10, 2026 03:05
@artokun

artokun commented Oct 1, 2026

Copy link
Copy Markdown
Owner

Limited maintenance audit — October 1, 2026.

Scope: upgrading development Node types to a new major requires compatibility work without changing the current runtime behavior. That toolchain migration is outside this release.

Closing this PR does not close or mark the underlying bug as fixed. Conflicts and age were not used as quality criteria. Automatic issue reporting remains disabled.

@artokun artokun closed this Oct 1, 2026
@dependabot @github

dependabot Bot commented on behalf of github Oct 1, 2026

Copy link
Copy Markdown
Contributor Author

OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting @dependabot ignore this major version or @dependabot ignore this minor version. You can also ignore all major, minor, or patch releases for a dependency by adding an ignore condition with the desired update_types to your config file.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.

@dependabot
dependabot Bot deleted the dependabot/npm_and_yarn/types/node-26.4.0 branch October 1, 2026 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant