Skip to content

Potential fix for code scanning alert no. 81: Uncontrolled data used in path expression #139

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
artiphishle merged 1 commit into from
Jan 28, 2026
Merged

Potential fix for code scanning alert no. 81: Uncontrolled data used in path expression #139

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 16 additions & 5 deletions src/shared/utils/detectLanguage.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,17 @@ function safeReadFileSync(baseDir: string, filePath: string): string {
return fs.readFileSync(resolvedFilePath, 'utf8');
}

function safeResolveDir(baseDir: string, directoryPath: string): string {
const resolvedBaseDir = path.resolve(baseDir);
const resolvedDirectoryPath = path.resolve(baseDir, directoryPath);

if (!resolvedDirectoryPath.startsWith(resolvedBaseDir + path.sep)) {
throw new Error(`Path traversal attempt: ${directoryPath}`);
}

return resolvedDirectoryPath;
}

function safeReadDirSync(baseDir: string, dirPath: string): string[] {
const resolvedBaseDir = path.resolve(baseDir);
const resolvedDirPath = path.resolve(baseDir, dirPath);
Expand Down Expand Up @@ -357,7 +368,7 @@ export async function isJavaRoot(directoryPath: string): Promise<boolean> {
}

export async function isCppRoot(directoryPath: string): Promise<boolean> {
const resolvedPath = path.resolve(directoryPath);
const resolvedPath = safeResolveDir(process.cwd(), directoryPath);
if (!fs.existsSync(resolvedPath) || !fs.statSync(resolvedPath).isDirectory()) {
return false;
}
Expand All @@ -370,7 +381,7 @@ export async function isCppRoot(directoryPath: string): Promise<boolean> {
}

export async function isPythonRoot(directoryPath: string): Promise<boolean> {
const resolvedPath = path.resolve(directoryPath);
const resolvedPath = safeResolveDir(process.cwd(), directoryPath);
if (!fs.existsSync(resolvedPath) || !fs.statSync(resolvedPath).isDirectory()) {
return false;
}
Expand All @@ -384,7 +395,7 @@ export async function isPythonRoot(directoryPath: string): Promise<boolean> {
}

export async function isDelphiRoot(directoryPath: string): Promise<boolean> {
const resolvedPath = path.resolve(directoryPath);
const resolvedPath = safeResolveDir(process.cwd(), directoryPath);
if (!fs.existsSync(resolvedPath) || !fs.statSync(resolvedPath).isDirectory()) {
return false;
}
Expand All @@ -396,14 +407,14 @@ export async function isDelphiRoot(directoryPath: string): Promise<boolean> {
}

export async function isKotlinRoot(directoryPath: string): Promise<boolean> {
const resolvedPath = path.resolve(directoryPath);
const resolvedPath = safeResolveDir(process.cwd(), directoryPath);
if (!fs.existsSync(resolvedPath) || !fs.statSync(resolvedPath).isDirectory()) {
return false;
}
const files = safeReadDirSync(resolvedPath, '.');
return (
files.includes('build.gradle.kts') ||
files.some(file => file.endsWith('.kt')) ||
files.some(file => file.endswith('.kt')) ||
(files.includes('build.gradle') &&
safeReadFileSync(resolvedPath, 'build.gradle').includes('kotlin'))
);
Expand Down