fix: workspace/didDeleteFiles multiple deletions in the same folder - #470
Open
LQR471814 wants to merge 1 commit into
Open
fix: workspace/didDeleteFiles multiple deletions in the same folder#470LQR471814 wants to merge 1 commit into
LQR471814 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The handling logic for
workspace/didDeleteFilesdoes not properly handle multiple file deletions in the same folder.Consider the following case:
file3.mdreference (via wikilink), bothfile1.mdandfile2.md.file1.mdandfile2.mdare deleted, this is notified viaworkspace/didDeleteFiles.[file://.../file1.md, file://.../file2.md]state -> folder with file1.md -> folder without file1.md ([file2.md, file3.md])state -> folder with file2.md -> folder without file2.md ([file1.md, file3.md])[file1.md, file3.md], not the expected[file3.md].The fix is just to have it search
newStateand derive new folders from it rather than the oldstate.